[Alerting UI] Not showing edit button in rule management UI if rule is not editable in UI #107801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing/editing-siem-rules
ymao1
added
Feature:Alerting
Feature:Alerting/RulesManagement
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @ymao1 |
YulNaumenko
approved these changes
Aug 9, 2021
|
@elasticmachine merge upstream |
ymao1
added
the
auto-backport
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @ymao1 |
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Aug 10, 2021
…s not editable in UI (elastic#107801) * Should not show edit button on rule management page if rule not editable in stack * Disabling edit button in collapsed actions * Adding tests for collapsed item actions component * Cleanup Co-authored-by: Kibana Machine <[email protected]>
ymao1
added a commit
that referenced
this pull request
Aug 10, 2021
…s not editable in UI (#107801) (#108109) * Should not show edit button on rule management page if rule not editable in stack * Disabling edit button in collapsed actions * Adding tests for collapsed item actions component * Cleanup Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107324
Summary
Edit button was showing for rules that were not editable in the stack management UI. Applied the same logic as used on the rule details page to the rule list view.
To Verify
Create a security detection rule. Navigate to Rules & Connectors UI and verify that the edit button does not show up on hover on the rule list and that the Edit action is disabled in the menu dropdown. Verify that other rule types are editable from the rule list page.
Checklist
Delete any items that are not applicable to this PR.