-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][RAC] - Update UI signal references #107713
Changes from 24 commits
774a475
c3710c0
d2f8e25
02123b2
9e83cd6
bf0bcb4
8358664
ece0e16
3c3850a
14e14df
b3eb265
ec9773a
3050f82
bfa882b
ecb4418
251f9e4
7cfc661
90358f3
a603a57
53a9439
e4b5397
5c3114e
a91ad1c
36de655
da099ba
376b68c
b54b767
12b7f17
d572a2e
d46dd24
68f3085
d1bdecf
2d157fa
fbef5b6
551629f
577376a
756470a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ import { EventEcs } from './event'; | |
import { FileEcs } from './file'; | ||
import { GeoEcs } from './geo'; | ||
import { HostEcs } from './host'; | ||
import { KibanaEcs } from './kibana'; | ||
import { NetworkEcs } from './network'; | ||
import { RegistryEcs } from './registry'; | ||
import { RuleEcs } from './rule'; | ||
|
@@ -45,6 +46,7 @@ export interface Ecs { | |
event?: EventEcs; | ||
geo?: GeoEcs; | ||
host?: HostEcs; | ||
kibana?: KibanaEcs; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Were you able to verify that these are coming back as nested objects, rather than a flattened set of key/values at the top level of the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
network?: NetworkEcs; | ||
registry?: RegistryEcs; | ||
rule?: RuleEcs; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { RuleEcs } from '../rule'; | ||
|
||
export interface KibanaEcs { | ||
alert?: { | ||
rule?: RuleEcs; | ||
original_time?: string[]; | ||
status?: string[]; | ||
group?: { | ||
id?: string[]; | ||
}; | ||
threshold_result?: unknown; | ||
}; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,9 +5,10 @@ | |
* 2.0. | ||
*/ | ||
|
||
import { eventDetailsFormattedFields, eventHit } from '@kbn/securitysolution-t-grid'; | ||
import { ALERT_RULE_NAME, ALERT_WORKFLOW_STATUS } from '@kbn/rule-data-utils'; | ||
import { EventHit, EventSource } from '../search_strategy'; | ||
import { getDataFromFieldsHits, getDataFromSourceHits, getDataSafety } from './field_formatters'; | ||
import { eventDetailsFormattedFields, eventHit } from '@kbn/securitysolution-t-grid'; | ||
|
||
describe('Events Details Helpers', () => { | ||
const fields: EventHit['fields'] = eventHit.fields; | ||
|
@@ -135,8 +136,8 @@ describe('Events Details Helpers', () => { | |
it('#getDataFromSourceHits', () => { | ||
const _source: EventSource = { | ||
'@timestamp': '2021-02-24T00:41:06.527Z', | ||
'signal.status': 'open', | ||
'signal.rule.name': 'Rawr', | ||
[ALERT_WORKFLOW_STATUS]: 'open', | ||
[ALERT_RULE_NAME]: 'Rawr', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rawr 😂 |
||
'threat.indicator': [ | ||
{ | ||
provider: 'yourself', | ||
|
@@ -161,15 +162,15 @@ describe('Events Details Helpers', () => { | |
isObjectArray: false, | ||
}, | ||
{ | ||
category: 'signal', | ||
field: 'signal.status', | ||
category: 'kibana', | ||
field: ALERT_WORKFLOW_STATUS, | ||
values: ['open'], | ||
originalValue: ['open'], | ||
isObjectArray: false, | ||
}, | ||
{ | ||
category: 'signal', | ||
field: 'signal.rule.name', | ||
category: 'kibana', | ||
field: ALERT_RULE_NAME, | ||
values: ['Rawr'], | ||
originalValue: ['Rawr'], | ||
isObjectArray: false, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this mapping from/to? As far as I can tell, it's only used in
eventFieldsMap
and that map doesn't appear to be used by anything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, this file is actually ported across three different plugins and I don't think any of them are being used. I'll delete them and see what happens 🤷🏾♂️