[Security Solution][Detections] Cleanup after ExecLog integration

[xcrzx]

Related to: #106461, #106466

Summary

It's a follow-up PR to clean up leftovers after ExecutionLog integration.

Notable changes:

Removed RuleStatusService

RuleStatusService contained mainly logic related to Saved Objects implementation which was moved to rule_execution_log/saved_objects_adapter. All usages of RuleStatusService were replaced with RuleExecutionLogClient.

Before:

const ruleStatusService = await ruleStatusServiceFactory({
  spaceId,
  alertId,
  ruleStatusClient,
});

await ruleStatusService.error(message, { 
  bulkCreateTimeDurations: result.bulkCreateTimes,
  searchAfterTimeDurations: result.searchAfterTimes, 
});

After:

await ruleStatusClient.logStatusChange({
  spaceId,
  ruleId: alertId,
  newStatus: RuleExecutionStatus.failed,
  message,
  metrics: { 
    bulkCreateTimeDurations: result.bulkCreateTimes,
    searchAfterTimeDurations: result.searchAfterTimes,  
  },
});

RuleExecutionLogClient interface changes

+ /**
+  * @deprecated LegacyMetrics are only kept here for backward compatibility
+  * and should be replaced by ExecutionMetric in the future
+  */
+ export interface LegacyMetrics {
+   searchAfterTimeDurations?: string[];
+   bulkCreateTimeDurations?: string[];
+   lastLookBackDate?: string;
+   gap?: string;
+ }

 export interface LogStatusChangeArgs {
   ruleId: string;
   spaceId: string;
   newStatus: RuleExecutionStatus;
   namespace?: string;
   message?: string;
+  metrics?: LegacyMetrics;
 }

 export interface IRuleExecutionLogClient {
   find: (args: FindExecutionLogArgs) => Promise<Array<SavedObjectsFindResult<IRuleStatusSOAttributes>>>;
   findBulk: (args: FindBulkExecutionLogArgs) => Promise<FindBulkExecutionLogResponse>;
   update: (args: UpdateExecutionLogArgs) => Promise<void>;
   delete: (id: string) => Promise<void>;
-  create: (args: CreateExecutionLogArgs) => Promise<SavedObject<IRuleStatusSOAttributes>>;
   logStatusChange: (args: LogStatusChangeArgs) => Promise<void>;
   logExecutionMetric: <T extends ExecutionMetric>(args: ExecutionMetricArgs<T>) => Promise<void>;
 }

• create() method was removed in favor of more specific logStatusChange() and logExecutionMetric() methods.
• logStatusChange() method arguments now accept metrics object to simulate behavior of the old RuleStatusService. This is a temporary solution. In the future we should write all execution metrics separately using logExecutionMetric().

RuleStatusSavedObjectsClient moved to rule_execution_log/saved_objects_adapter

RuleStatusSavedObjectsClient was moved to rule_execution_log/saved_objects_adapter directory. It is considered internal implementation of the RuleExecutionLog from now on and should not be used directly.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/security-detections-response (Team:Detections and Resp)

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[banderror]

Looks good to me overall 👍

What I did:

• reviewed the code changes and compared them to the deleted implementation of rule status service
• tested the PR locally, didn't notice any issues

Thank you for this cleanup. I left a few small comments.

[banderror]

Awesome, thank you for the changes. Let's merge this guy 🙂 🚀

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 2c1be08
• Storybooks Preview

Metrics [docs]

✅ unchanged

History

• 💚 Build #147653 succeeded 28bc8bbaac2c9a3b9561a2efe3720d791eadd487
• 💔 Build #147388 failed d69bf039924dcb6ceaa8961a2b5fbe37021ca35a
• 💔 Build #147207 failed cdd02ffa4e48625031e182941362b7cff5e7d494
• 💚 Build #146873 succeeded d7f65640278952b1e92bcef34de39ef2383b260a
• 💚 Build #145804 succeeded 57d7cfdd64b1fc9ef711af0b30d6f645fe2abe49

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @xcrzx

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.