[Security Solution][RAC] - Add reason field #107532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolo24
added
release_note:enhancement
v8.0.0
Team:Threat Hunting
michaelolo24
force-pushed
the
add-security-reason-field
branch
from
d264522 to
2218a3b
Compare
michaelolo24
added
the
auto-backport
michaelolo24
force-pushed
the
add-security-reason-field
branch
from
1cf3196 to
8d40ac5
Compare
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
.../security_solution/server/lib/detection_engine/rule_types/factories/utils/build_bulk_body.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/detection_engine/signals/build_bulk_body.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/detection_engine/signals/build_bulk_body.ts
Outdated
Show resolved
Hide resolved
machadoum
reviewed
Aug 11, 2021
| export type BuildReasonMessage = (args: BuildReasonMessageArgs) => string; | ||
|
|
||
| /** | ||
| * Currently all security solution rule types share a commone reason message string. This function composes that string |
There was a problem hiding this comment.
updated, thanks!
| if (mergedDoc?.fields) { | ||
| hostName = mergedDoc.fields['host.name'] != null ? mergedDoc.fields['host.name'] : hostName; | ||
| userName = mergedDoc.fields['user.name'] != null ? mergedDoc.fields['user.name'] : userName; | ||
| timestampForReason = |
There was a problem hiding this comment.
nit: This ternary operator chain is a bit hard to read. I think that a simple if/else statement might be more readable.
There was a problem hiding this comment.
Yea, I changed it. Thanks!
There was a problem hiding this comment.
it should just be the passed in timestamp. So removed all this logic
machadoum
approved these changes
Aug 11, 2021
This was referenced Aug 11, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
michaelolo24
added a commit
to michaelolo24/kibana
that referenced
this pull request
Aug 11, 2021
# Conflicts: # x-pack/plugins/security_solution/cypress/integration/detection_alerts/alerts_details.spec.ts
This was referenced Aug 11, 2021
michaelolo24
added a commit
to michaelolo24/kibana
that referenced
this pull request
Aug 12, 2021
# Conflicts: # x-pack/plugins/security_solution/cypress/integration/detection_alerts/alerts_details.spec.ts
michaelolo24
added a commit
that referenced
this pull request
Aug 12, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
signal.reason/kibana.alert.reasonfield in security_solution as seen below.