Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability RAC] change alerts table filter text box placeholder #107366

Merged
merged 4 commits into from
Aug 4, 2021
Merged

[Observability RAC] change alerts table filter text box placeholder #107366

merged 4 commits into from
Aug 4, 2021

Conversation

mgiota
Copy link
Contributor

@mgiota mgiota commented Aug 2, 2021

Fixes #105235

The KQL query input in the alerts table filter bar now shows a placeholder which represents a query appropriate to the table.

"rule.id" : "metrics.alert.threshold"

@mgiota mgiota added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Aug 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@mgiota mgiota added v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 2, 2021
@mgiota
Copy link
Contributor Author

mgiota commented Aug 2, 2021

@elasticmachine merge upstream

@mgiota mgiota requested a review from weltenwort August 3, 2021 11:14
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 490.7KB 490.7KB -33.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

weltenwort
weltenwort approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@mgiota mgiota merged commit 36f5930 into elastic:master Aug 4, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107366 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 6, 2021
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@mgiota @kibanamachine @vadimkibana
[Observability RAC] change alerts table filter text box placeholder (e…
2f4cdcd 
…lastic#107366)

* change alerts table filter text box placeholder

* update alerts table placeholder to use the status field

* use threshold for the alerts table placeholder

Co-authored-by: Kibana Machine <[email protected]>
@paulb-elastic
Copy link
Contributor

@mgiota will you arrnage for this to be backported? Thanks.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107366 or prevent reminders by adding the backport:skip label.

@weltenwort weltenwort added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 9, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 9, 2021
@mgiota @kibanamachine
[Observability RAC] change alerts table filter text box placeholder (e…
9033d8d 
…lastic#107366)

* change alerts table filter text box placeholder

* update alerts table placeholder to use the status field

* use threshold for the alerts table placeholder

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Aug 9, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 9, 2021
@kibanamachine @mgiota
[Observability RAC] change alerts table filter text box placeholder (#…
81e9141 
…107366) (#107884)

* change alerts table filter text box placeholder

* update alerts table placeholder to use the status field

* use threshold for the alerts table placeholder

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: mgiota <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 9, 2021
@mgiota
Copy link
Contributor Author

mgiota commented Aug 11, 2021 •
edited
Loading

@paulb-elastic Thanks for reminding this! @weltenwort Looks like you took care of this, thx!

@mgiota mgiota mentioned this pull request Aug 11, 2021
Closed
12 tasks
@mgiota mgiota deleted the 105235_filter_text_box_placeholder branch January 4, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Observability RAC] Improve alerts table filter text box placeholder
5 participants
@mgiota @elasticmachine @kibanamachine @paulb-elastic @weltenwort