Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[discover] use IndexPattern instead of IIndexPattern #107198

Merged
merged 2 commits into from
Aug 2, 2021
Merged

[discover] use IndexPattern instead of IIndexPattern #107198

merged 2 commits into from
Aug 2, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jul 29, 2021 •
edited
Loading

Summary

Use IndexPattern instead of IIndexPattern as IIndexPattern is deprecated due to too much ambiguity in its definition.

@mattkime mattkime mentioned this pull request Jul 29, 2021
Closed
20 tasks
@mattkime mattkime changed the title use IndexPattern instead of IIndexPattern [discover] use IndexPattern instead of IIndexPattern Jul 29, 2021
@mattkime mattkime added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0 labels Jul 29, 2021
@mattkime mattkime marked this pull request as ready for review July 29, 2021 18:59
@mattkime mattkime requested a review from a team July 29, 2021 18:59
@mattkime
Copy link
Contributor Author

mattkime commented Aug 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
discover 129 119 -10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal
kertal approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review, only types change

@mattkime mattkime merged commit 7e12ea8 into elastic:master Aug 2, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2021
@mattkime @kibanamachine
use IndexPattern instead of IIndexPattern (elastic#107198)
85b7147 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Aug 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 2, 2021
@kibanamachine @mattkime
use IndexPattern instead of IIndexPattern (#107198) (#107389)
432a543 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Matthew Kime <[email protected]>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@mattkime @kibanamachine @vadimkibana
use IndexPattern instead of IIndexPattern (elastic#107198)
c153ec7 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattkime @kibanamachine @kertal