[apm] use IndexPattern instead of IIndexPattern #107187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
mattkime
changed the title
mattkime
added
auto-backport
|
@elasticmachine merge upstream |
|
Pinging @elastic/apm-ui (Team:apm) |
💚 Build SucceededMetrics [docs]History
To update your PR or re-run it, just comment with: |
sorenlouv
reviewed
Aug 1, 2021
| const res = convertKueryToEsQuery(inputValue, indexPattern); | ||
| const res = convertKueryToEsQuery( | ||
| inputValue, | ||
| indexPattern as IndexPattern |
There was a problem hiding this comment.
Is as IndexPattern really needed?
There was a problem hiding this comment.
it is, indexPattern is typed as IndexPatternTitleAndFields which convertKueryToEsQuery complains about.
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 2, 2021
* use IndexPattern instead of IIndexPattern * typefix Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 2, 2021
* use IndexPattern instead of IIndexPattern * typefix Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Matthew Kime <[email protected]>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
* use IndexPattern instead of IIndexPattern * typefix Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
IndexPatterninstead ofIIndexPatternasIIndexPatternis deprecated due to too much ambiguity in its definition.