[Security solution] [RAC] Add checkbox control column to t-grid #107144

machadoum · 2021-07-29T11:46:48Z

Summary

Add checkbox control column to t-grid. It impacts the security and observability alerts table.

Observability before changes

Observability after changes

Security Before changes `t-gridEnabled: true`

Security after changes `t-gridEnabled: true`

Checklist

Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

x-pack/plugins/security_solution/common/experimental_features.ts

x-pack/plugins/timelines/public/components/t_grid/body/control_columns/checkbox.test.tsx

x-pack/plugins/timelines/public/components/t_grid/body/index.tsx

elasticmachine · 2021-07-30T09:14:37Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2021-07-30T09:14:37Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

semd · 2021-07-30T13:33:46Z

I have tested the feature locally, Everything works as expected 👍
The only thing is that I found a misalignment between the header and the row checkboxes:

@elastic/eui-design This is caused by the EuiDataGrid using gridStyle={{border: 'none'}}.
The border: none; rule is applied to the header:

but the row divs only have border-color: transparent !important;:

semd

L ✅ TM!!
Thanks for your help Pablo!

machadoum · 2021-08-02T08:18:44Z

@elasticmachine merge upstream

machadoum · 2021-08-02T13:33:34Z

@elasticmachine merge upstream

kibanamachine · 2021-08-02T15:57:56Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 987fbb8
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup1

Test Failures

Kibana Pipeline / general / APM API Integration tests (trial).x-pack/test/apm_api_integration/tests/correlations/latency_overall·ts.APM API tests trial apm_8.0.0 correlations latency overall with data and default args returns overall distribution

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/107109

[00:00:00]       │
[00:00:00]         └-: APM API tests
[00:00:00]           └-> "before all" hook in "APM API tests"
[00:00:00]           └-: trial
[00:00:00]             └-> "before all" hook in "trial"
[00:00:12]             └-: apm_8.0.0
[00:00:12]               └-> "before all" hook in "apm_8.0.0"
[00:00:12]               └-> "before all" hook: runBefore in "apm_8.0.0"
[00:00:12]                 │ info (0ms) Loading apm_8.0.0
[00:00:12]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Loading "mappings.json"
[00:00:12]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Loading "data.json.gz"
[00:00:12]                 │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_1/kWECniX3SaiuwXJ8RLiw6A] deleting index
[00:00:12]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Deleted existing index ".kibana_1"
[00:00:12]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:00:12]                 │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_1]
[00:00:12]                 │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_1][0]]"
[00:00:12]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Created index ".kibana_1"
[00:00:12]                 │ debg [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"1","number_of_shards":"1","priority":"10","refresh_interval":"1s"}}
[00:00:12]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.ml-anomalies-shared] creating index, cause [api], templates [.ml-anomalies-], shards [1]/[1]
[00:00:12]                 │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.ml-anomalies-shared]
[00:00:12]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.ml-annotations-6] creating index, cause [api], templates [], shards [1]/[1]
[00:00:12]                 │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.ml-annotations-6]
[00:00:13]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Created index ".ml-anomalies-shared"
[00:00:13]                 │ debg [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] ".ml-anomalies-shared" settings {"index":{"auto_expand_replicas":"0-1","blocks":{"read_only_allow_delete":"false"},"hidden":"true","number_of_replicas":"1","number_of_shards":"1","translog":{"durability":"async"}}}
[00:00:13]                 │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.ml-annotations-6][0]]])." previous.health="YELLOW" reason="shards started [[.ml-annotations-6][0]]"
[00:00:13]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.ml-config] creating index, cause [api], templates [], shards [1]/[1]
[00:00:13]                 │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.ml-config]
[00:00:13]                 │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.ml-config][0]]])." previous.health="YELLOW" reason="shards started [[.ml-config][0]]"
[00:00:13]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Created index ".ml-config"
[00:00:13]                 │ debg [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] ".ml-config" settings {"index":{"auto_expand_replicas":"0-1","max_result_window":"10000","number_of_replicas":"1","number_of_shards":"1"}}
[00:00:13]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [apm-8.0.0-error-000002] creating index, cause [api], templates [], shards [1]/[1]
[00:00:13]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Created index "apm-8.0.0-error-000002"
[00:00:13]                 │ debg [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] "apm-8.0.0-error-000002" settings {"index":{"blocks":{"read_only_allow_delete":"false"},"codec":"best_compression","lifecycle":{"name":"apm-rollover-30-days","rollover_alias":"apm-8.0.0-error"},"mapping":{"total_fields":{"limit":"2000"}},"max_docvalue_fields_search":"200","number_of_replicas":"1","number_of_shards":"1","refresh_interval":"5s"}}
[00:00:13]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [apm-8.0.0-metric-000002] creating index, cause [api], templates [], shards [1]/[1]
[00:00:13]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Created index "apm-8.0.0-metric-000002"
[00:00:13]                 │ debg [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] "apm-8.0.0-metric-000002" settings {"index":{"blocks":{"read_only_allow_delete":"false"},"codec":"best_compression","lifecycle":{"name":"apm-rollover-30-days","rollover_alias":"apm-8.0.0-metric"},"mapping":{"total_fields":{"limit":"2000"}},"max_docvalue_fields_search":"200","number_of_replicas":"1","number_of_shards":"1","refresh_interval":"5s"}}
[00:00:13]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [apm-8.0.0-span-000008] creating index, cause [api], templates [], shards [1]/[1]
[00:00:13]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Created index "apm-8.0.0-span-000008"
[00:00:13]                 │ debg [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] "apm-8.0.0-span-000008" settings {"index":{"codec":"best_compression","lifecycle":{"name":"apm-rollover-30-days","rollover_alias":"apm-8.0.0-span"},"mapping":{"total_fields":{"limit":"2000"}},"max_docvalue_fields_search":"200","number_of_replicas":"1","number_of_shards":"1","refresh_interval":"5s"}}
[00:00:13]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [apm-8.0.0-transaction-000002] creating index, cause [api], templates [], shards [1]/[1]
[00:00:13]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Created index "apm-8.0.0-transaction-000002"
[00:00:13]                 │ debg [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] "apm-8.0.0-transaction-000002" settings {"index":{"codec":"best_compression","lifecycle":{"name":"apm-rollover-30-days","rollover_alias":"apm-8.0.0-transaction"},"mapping":{"total_fields":{"limit":"2000"}},"max_docvalue_fields_search":"200","number_of_replicas":"1","number_of_shards":"1","refresh_interval":"5s"}}
[00:00:22]                 │ info progress: 33443
[00:00:32]                 │ info progress: 56997
[00:00:40]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Indexed 29 docs into ".kibana_1"
[00:00:40]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Indexed 63 docs into ".ml-anomalies-shared"
[00:00:40]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Indexed 2 docs into ".ml-config"
[00:00:40]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Indexed 420 docs into "apm-8.0.0-error-000002"
[00:00:40]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Indexed 31341 docs into "apm-8.0.0-metric-000002"
[00:00:40]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Indexed 37854 docs into "apm-8.0.0-span-000008"
[00:00:40]                 │ info [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Indexed 7013 docs into "apm-8.0.0-transaction-000002"
[00:00:40]                 │ debg Migrating saved objects
[00:00:40]                 │ proc [kibana]   log   [14:47:56.580] [info][savedobjects-service] Detected mapping change in "properties.telemetry"
[00:00:40]                 │ proc [kibana]   log   [14:47:56.583] [info][savedobjects-service] Creating index .kibana_2.
[00:00:40]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:00:40]                 │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:40]                 │ proc [kibana]   log   [14:47:56.696] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:00:40]                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_2/G3Auu0vhRAaZK29renUwsQ] update_mapping [_doc]
[00:00:40]                 │ proc [kibana]   log   [14:47:56.786] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:00:40]                 │ proc [kibana]   log   [14:47:56.855] [info][savedobjects-service] Finished in 275ms.
[00:00:40]                 │ debg [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Migrated Kibana index after loading Kibana data
[00:00:41]                 │ debg [x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0] Ensured that default space exists in .kibana
[00:00:41]                 │ info (28673ms) Loaded all archives
[00:00:41]               └-: correlations latency overall with data and default args
[00:00:41]                 └-> "before all" hook for "returns successfully"
[00:00:41]                 └-> "before all" hook for "returns successfully"
[00:00:42]                 └-> returns successfully
[00:00:42]                   └-> "before each" hook: global before each for "returns successfully"
[00:00:42]                   └- ✓ pass  (1ms) "APM API tests trial apm_8.0.0 correlations latency overall with data and default args returns successfully"
[00:00:42]                 └-> returns overall distribution
[00:00:42]                   └-> "before each" hook: global before each for "returns overall distribution"
[00:00:42]                   └- ✖ fail: APM API tests trial apm_8.0.0 correlations latency overall with data and default args returns overall distribution
[00:00:42]                   │      Error: expect(received).toMatchInlineSnapshot(snapshot)
[00:00:42]                   │ 
[00:00:42]                   │ Snapshot name: `APM API tests trial apm_8.0.0 correlations latency overall with data and default args returns overall distribution 2`
[00:00:42]                   │ 
[00:00:42]                   │ Snapshot: "5.0e+6"
[00:00:42]                   │ Received: "4.9e+6"
[00:00:42]                   │       at toMatchInline (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/snapshots/decorate_snapshot_ui.js:195:11)
[00:00:42]                   │       at Context.<anonymous> (test/apm_api_integration/tests/correlations/latency_overall.ts:64:67)
[00:00:42]                   │       at Object.apply (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:30)
[00:00:42]                   │ 
[00:00:42]                   │

Stack Trace

Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `APM API tests trial apm_8.0.0 correlations latency overall with data and default args returns overall distribution 2`

Snapshot: "5.0e+6"
Received: "4.9e+6"
    at toMatchInline (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/snapshots/decorate_snapshot_ui.js:195:11)
    at Context.<anonymous> (test/apm_api_integration/tests/correlations/latency_overall.ts:64:67)
    at Object.apply (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:30)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`timelines`	233	236	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.4MB	6.4MB	+76.0B
`timelines`	242.5KB	245.1KB	+2.6KB
total			+2.6KB

History

💔 Build #142198 failed 1817cb9
💚 Build #141935 succeeded 334c2b4
💚 Build #141883 succeeded 19e8a7446ec47769500dce4cc31b5ed118b90f62
💔 Build #141622 failed 3ac0f062ccbb05dfa9fb65cbf818933a0dff39c3
💔 Build #141600 failed 49abbf8870f89df887aa806bb61d0c2be497eead

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

…tic#107144) * Add checkbox control column to t-grid * Add unit tests * Update translations Co-authored-by: Kibana Machine <[email protected]>

) (#107630) * Add checkbox control column to t-grid * Add unit tests * Update translations Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

…tic#107144) * Add checkbox control column to t-grid * Add unit tests * Update translations Co-authored-by: Kibana Machine <[email protected]>

machadoum commented Jul 29, 2021

View reviewed changes

x-pack/plugins/security_solution/common/experimental_features.ts Outdated Show resolved Hide resolved

machadoum commented Jul 29, 2021

View reviewed changes

x-pack/plugins/timelines/public/components/t_grid/body/control_columns/checkbox.test.tsx Outdated Show resolved Hide resolved

machadoum commented Jul 29, 2021

View reviewed changes

x-pack/plugins/timelines/public/components/t_grid/body/index.tsx Show resolved Hide resolved

machadoum commented Jul 29, 2021

View reviewed changes

x-pack/plugins/timelines/public/components/t_grid/body/index.tsx Outdated Show resolved Hide resolved

machadoum force-pushed the rac-alerts-table-checkboxes branch from 49abbf8 to 3ac0f06 Compare July 29, 2021 13:10

semd reviewed Jul 29, 2021

View reviewed changes

x-pack/plugins/timelines/public/components/t_grid/body/index.tsx Show resolved Hide resolved

machadoum changed the title ~~[WIP] Add checkbox control column to t-grid~~ [Security solution] [RAC] Add checkbox control column to t-grid Jul 30, 2021

machadoum force-pushed the rac-alerts-table-checkboxes branch from 3ac0f06 to 19e8a74 Compare July 30, 2021 09:05

machadoum marked this pull request as ready for review July 30, 2021 09:13

machadoum requested review from a team as code owners July 30, 2021 09:13

machadoum self-assigned this Jul 30, 2021

machadoum added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0 labels Jul 30, 2021

machadoum requested a review from andrew-goldstein July 30, 2021 12:10

machadoum added 3 commits July 30, 2021 14:13

Add checkbox control column to t-grid

5c595c7

Add unit tests

00b2559

Update translations

334c2b4

machadoum force-pushed the rac-alerts-table-checkboxes branch from 19e8a74 to 334c2b4 Compare July 30, 2021 12:13

semd approved these changes Jul 30, 2021

View reviewed changes

cchaos mentioned this pull request Jul 30, 2021

[EuiDataGrid] Selection columns are not aligned elastic/eui#4997

Closed

Merge branch 'master' into rac-alerts-table-checkboxes

1817cb9

Merge branch 'master' into rac-alerts-table-checkboxes

987fbb8

machadoum merged commit 402702d into elastic:master Aug 3, 2021

machadoum mentioned this pull request Aug 4, 2021

[7.x] [Security solution] [RAC] Add checkbox control column to t-grid (#107144) #107630

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security solution] [RAC] Add checkbox control column to t-grid #107144

[Security solution] [RAC] Add checkbox control column to t-grid #107144

machadoum commented Jul 29, 2021 •

edited

Loading

elasticmachine commented Jul 30, 2021

elasticmachine commented Jul 30, 2021

semd commented Jul 30, 2021

semd left a comment

machadoum commented Aug 2, 2021

machadoum commented Aug 2, 2021

kibanamachine commented Aug 2, 2021

Standard Out

Stack Trace

[Security solution] [RAC] Add checkbox control column to t-grid #107144

[Security solution] [RAC] Add checkbox control column to t-grid #107144

Conversation

machadoum commented Jul 29, 2021 • edited Loading

Summary

Observability before changes

Observability after changes

Security Before changes t-gridEnabled: true

Security after changes t-gridEnabled: true

Checklist

elasticmachine commented Jul 30, 2021

elasticmachine commented Jul 30, 2021

semd commented Jul 30, 2021

semd left a comment

Choose a reason for hiding this comment

machadoum commented Aug 2, 2021

machadoum commented Aug 2, 2021

kibanamachine commented Aug 2, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

History

machadoum commented Jul 29, 2021 •

edited

Loading

Security Before changes `t-gridEnabled: true`

Security after changes `t-gridEnabled: true`