Make onChange in CodeEditor optional #107128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
changed the title
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsAPI count
API count missing comments
History
To update your PR or re-run it, just comment with: |
timroes
added
auto-backport
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
peteharverson
approved these changes
Jul 29, 2021
stratoula
approved these changes
Jul 29, 2021
vadimkibana
approved these changes
Jul 29, 2021
ThomThomson
approved these changes
Jul 29, 2021
💔 Backport failed
To backport manually run: |
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Jul 29, 2021
* Make onChang in CodeEditor optional * Update api docs # Conflicts: # api_docs/kibana_react.mdx
timroes
pushed a commit
that referenced
this pull request
Jul 29, 2021
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
* Make onChang in CodeEditor optional * Update api docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
onChangeproperty ofCodeEditoroptional, since it isn't required by Monaco and in a lot of places we use it in readOnly mode we currently need to pass in an noop function.Checklist
Delete any items that are not applicable to this PR.
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)[ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)[ ] This was checked for cross-browser compatibility