remove elasticsearch package imports from reporting #107126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
v8.0.0
release_note:skip
74 tasks
mshustov
commented
Jul 29, 2021
| @@ -77,24 +74,6 @@ export function registerJobGenerationRoutes(reporting: ReportingCore, logger: Lo | |||
| }); | |||
| } | |||
|
|
|||
| if (err instanceof esErrors['401']) { | |||
There was a problem hiding this comment.
Reporting doesn't have access to the legacy client errors, so this code is dead and I removed it. If you considered this logic is necessary, please update it in a follow-up.
There was a problem hiding this comment.
It looks like this code was not doing anything special but adding a custom message on top of an error code. These error codes seem appropriate: I'm not seeing unexpected transformation of these codes to a custom message. I don't think this logic was necessary.
mshustov
added
the
auto-backport
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 30, 2021
* remove elasticsearch package imports from reporting * remove dead code
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jul 31, 2021
* remove elasticsearch package imports from reporting * remove dead code Co-authored-by: Mikhail Shustov <[email protected]>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
* remove elasticsearch package imports from reporting * remove dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use typings imported from
@elastic/elasticsearchpackage