Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Services inventory: add time comparisons to match service overview design #107094

Merged

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Jul 28, 2021

closes #106318

service.inventory.mov

@cauemarcondes cauemarcondes added apm:ux-refresh auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement v7.15.0 labels Jul 28, 2021
@cauemarcondes cauemarcondes marked this pull request as ready for review July 29, 2021 17:04
@cauemarcondes cauemarcondes requested a review from a team as a code owner July 29, 2021 17:04
@cauemarcondes cauemarcondes requested a review from formgeist July 29, 2021 17:04
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes cauemarcondes requested a review from dgieselaar July 30, 2021 18:06
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! 👍 Super excited to get these comparisons into the service inventory as well.

I noticed an "edge-case" where one of the services is not reporting any data (and only has a single data point), I wonder if there's nothing rendered in the chart, we should show the N/A state and the icon in the chart cell?

Screenshot 2021-08-02 at 10 09 24

Screenshot 2021-08-02 at 10 09 30

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

return { servicesData: data, servicesStatus: status };
return {
servicesData: mainStatistics,
servicesStatus: status,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we only interested in the mainStatistics status, and not also the comparison status?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the status from the mainStatistics is going to be used to show an error message if that was the case. And if any happened while fetching the comparison statistics it just wouldn't show the sparklines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the comparison statistics is used to define if the loading spinner should be visible or not. https://github.com/elastic/kibana/pull/107094/files#diff-1f8752bfc4d79520010b5d507b96176f454830da1dc8e2091578f66e42007d02R145-R148

@@ -23,10 +22,6 @@ interface Props {
export function NoServicesMessage({ historicalDataFound, status }: Props) {
const upgradeAssistantHref = useUpgradeAssistantHref();

if (status === 'loading') {
return <LoadingStatePrompt />;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this no longer needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cauemarcondes cauemarcondes requested a review from sorenlouv August 3, 2021 13:17
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cauemarcondes cauemarcondes enabled auto-merge (squash) August 3, 2021 20:58
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +1.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit ca137ea into elastic:master Aug 3, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 3, 2021
…iew design (elastic#107094)

* adding comparison to inventory page

* new api to get detailed statistics

* show comparison data

* adding api test

* fixing unit test

* fixing ts issue

* adding loading to table

* refactoring

* fixing TS issue

* addressing PR comments

* fixing merge

* addressing PR comments

* fixing api test

* adding comment

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 4, 2021
…iew design (#107094) (#107607)

* adding comparison to inventory page

* new api to get detailed statistics

* show comparison data

* adding api test

* fixing unit test

* fixing ts issue

* adding loading to table

* refactoring

* fixing TS issue

* addressing PR comments

* fixing merge

* addressing PR comments

* fixing api test

* adding comment

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Cauê Marcondes <[email protected]>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
…iew design (elastic#107094)

* adding comparison to inventory page

* new api to get detailed statistics

* show comparison data

* adding api test

* fixing unit test

* fixing ts issue

* adding loading to table

* refactoring

* fixing TS issue

* addressing PR comments

* fixing merge

* addressing PR comments

* fixing api test

* adding comment

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ux-refresh auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:APM All issues that need APM UI Team support v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Services inventory: add time comparisons to match service overview design
6 participants