Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [FieldFormats] Lazy load field formats editors (#106439) #106993

Merged
merged 1 commit into from
Jul 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@
* Side Public License, v 1.
*/

import { NumberFormatEditor } from '../number';
import { NumberFormatEditor } from '../number/number';
import { defaultState } from '../default';
import { formatId } from './constants';

export class BytesFormatEditor extends NumberFormatEditor {
static formatId = 'bytes';
static formatId = formatId;
state = {
...defaultState,
sampleInputs: [256, 1024, 5150000, 1990000000],
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

export const formatId = 'bytes';
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,10 @@
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/
import { formatId } from './constants';
import { FieldFormatEditorFactory } from '../types';

export { BytesFormatEditor } from './bytes';
export type { BytesFormatEditor } from './bytes';
export const bytesFormatEditorFactory: FieldFormatEditorFactory = () =>
import('./bytes').then((m) => m.BytesFormatEditor);
bytesFormatEditorFactory.formatId = formatId;
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ import { EuiBasicTable, EuiButton, EuiColorPicker, EuiFieldText, EuiSpacer } fro

import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n/react';
import { DefaultFormatEditor, FormatEditorProps } from '../default';
import { DefaultFormatEditor } from '../default/default';
import { formatId } from './constants';

import { fieldFormats } from '../../../../../../data/public';
import { FormatEditorProps } from '../types';

interface Color {
range?: string;
Expand All @@ -32,7 +34,7 @@ interface ColorFormatEditorFormatParams {
}

export class ColorFormatEditor extends DefaultFormatEditor<ColorFormatEditorFormatParams> {
static formatId = 'color';
static formatId = formatId;
constructor(props: FormatEditorProps<ColorFormatEditorFormatParams>) {
super(props);
this.onChange({
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

export const formatId = 'color';
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,10 @@
* Side Public License, v 1.
*/

export { ColorFormatEditor } from './color';
import { FieldFormatEditorFactory } from '../types';
import { formatId } from './constants';

export type { ColorFormatEditor } from './color';
export const colorFormatEditorFactory: FieldFormatEditorFactory = () =>
import('./color').then((m) => m.ColorFormatEditor);
colorFormatEditorFactory.formatId = formatId;
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

export const formatId = 'date';
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ import moment from 'moment';
import { EuiCode, EuiFieldText, EuiFormRow, EuiIcon, EuiLink } from '@elastic/eui';

import { FormattedMessage } from '@kbn/i18n/react';
import { DefaultFormatEditor, defaultState } from '../default';
import { DefaultFormatEditor, defaultState } from '../default/default';
import { formatId } from './constants';

import { FormatEditorSamples } from '../../samples';

Expand All @@ -21,7 +22,7 @@ interface DateFormatEditorFormatParams {
}

export class DateFormatEditor extends DefaultFormatEditor<DateFormatEditorFormatParams> {
static formatId = 'date';
static formatId = formatId;
state = {
...defaultState,
sampleInputs: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,10 @@
* Side Public License, v 1.
*/

export { DateFormatEditor } from './date';
import { FieldFormatEditorFactory } from '../types';
import { formatId } from './constants';

export type { DateFormatEditor } from './date';
export const dateFormatEditorFactory: FieldFormatEditorFactory = () =>
import('./date').then((m) => m.DateFormatEditor);
dateFormatEditorFactory.formatId = formatId;
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

export const formatId = 'date_nanos';
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import React, { Fragment } from 'react';
import { EuiCode, EuiFieldText, EuiFormRow, EuiIcon, EuiLink } from '@elastic/eui';

import { FormattedMessage } from '@kbn/i18n/react';
import { DefaultFormatEditor, defaultState } from '../default';
import { DefaultFormatEditor, defaultState } from '../default/default';
import { formatId } from './constants';

import { FormatEditorSamples } from '../../samples';

Expand All @@ -20,7 +21,7 @@ interface DateNanosFormatEditorFormatParams {
}

export class DateNanosFormatEditor extends DefaultFormatEditor<DateNanosFormatEditorFormatParams> {
static formatId = 'date_nanos';
static formatId = formatId;
state = {
...defaultState,
sampleInputs: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,10 @@
* Side Public License, v 1.
*/

export { DateNanosFormatEditor } from './date_nanos';
import { FieldFormatEditorFactory } from '../types';
import { formatId } from './constants';

export type { DateNanosFormatEditor } from './date_nanos';
export const dateNanosFormatEditorFactory: FieldFormatEditorFactory = () =>
import('./date_nanos').then((m) => m.DateNanosFormatEditor);
dateNanosFormatEditorFactory.formatId = formatId;
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

export const formatId = 'default';
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@
import React, { PureComponent, ReactText } from 'react';
import { i18n } from '@kbn/i18n';

import { FieldFormat, FieldFormatsContentType } from 'src/plugins/data/public';
import { FieldFormatsContentType } from 'src/plugins/data/public';
import { Sample, SampleInput } from '../../types';
import { FormatSelectEditorProps } from '../../field_format_editor';
import { FormatEditorProps } from '../types';
import { formatId } from './constants';

export const convertSampleInput = (
converter: (input: SampleInput) => string,
Expand Down Expand Up @@ -44,14 +45,6 @@ interface SampleInputs {
[key: string]: Array<ReactText[] | ReactText>;
}

export interface FormatEditorProps<P> {
fieldType: string;
format: FieldFormat;
formatParams: { type?: string } & P;
onChange: (newParams: Record<string, any>) => void;
onError: FormatSelectEditorProps['onError'];
}

export interface FormatEditorState {
sampleInputs: SampleInput[];
sampleConverterType: FieldFormatsContentType;
Expand All @@ -72,7 +65,7 @@ export class DefaultFormatEditor<P = {}, S = {}> extends PureComponent<
FormatEditorProps<P>,
FormatEditorState & S
> {
static formatId = 'default';
static formatId = formatId;
state = defaultState as FormatEditorState & S;

static getDerivedStateFromProps(nextProps: FormatEditorProps<{}>, state: FormatEditorState) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,13 @@
* Side Public License, v 1.
*/

export { DefaultFormatEditor, defaultState, FormatEditorProps, FormatEditorState } from './default';
import { FieldFormatEditorFactory } from '../types';
import { formatId } from './constants';

export { defaultState, FormatEditorState } from './default';
export type { FormatEditorProps } from '../types';
export type { DefaultFormatEditor } from './default';

export const defaultFormatEditorFactory: FieldFormatEditorFactory = () =>
import('./default').then((m) => m.DefaultFormatEditor);
defaultFormatEditorFactory.formatId = formatId;
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

export const formatId = 'duration';
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,11 @@ import { EuiFieldNumber, EuiFormRow, EuiSelect, EuiSwitch } from '@elastic/eui';

import { FormattedMessage } from '@kbn/i18n/react';
import { i18n } from '@kbn/i18n';
import {
DefaultFormatEditor,
defaultState,
FormatEditorProps,
FormatEditorState,
} from '../default';
import { DefaultFormatEditor, defaultState, FormatEditorState } from '../default/default';

import { FormatEditorSamples } from '../../samples';
import { formatId } from './constants';
import { FormatEditorProps } from '../types';

interface DurationFormatEditorState {
hasDecimalError: boolean;
Expand Down Expand Up @@ -49,7 +46,7 @@ export class DurationFormatEditor extends DefaultFormatEditor<
DurationFormatEditorFormatParams,
DurationFormatEditorState
> {
static formatId = 'duration';
static formatId = formatId;
state = {
...defaultState,
sampleInputs: [-123, 1, 12, 123, 658, 1988, 3857, 123292, 923528271],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,10 @@
* Side Public License, v 1.
*/

export { DurationFormatEditor } from './duration';
import { FieldFormatEditorFactory } from '../types';
import { formatId } from './constants';

export type { DurationFormatEditor } from './duration';
export const durationFormatEditorFactory: FieldFormatEditorFactory = () =>
import('./duration').then((m) => m.DurationFormatEditor);
durationFormatEditorFactory.formatId = formatId;
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

export const formatId = 'histogram';
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,17 @@ import React, { Fragment } from 'react';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n/react';
import { EuiSelect, EuiFieldText, EuiFormRow, EuiIcon, EuiLink } from '@elastic/eui';
import { DefaultFormatEditor, defaultState } from '../default';
import { DefaultFormatEditor, defaultState } from '../default/default';
import { FormatEditorSamples } from '../../samples';
import { formatId } from './constants';

export interface HistogramFormatEditorParams {
id: 'bytes' | 'percent' | 'number';
params: { pattern?: string } & Record<string, unknown>;
}

export class HistogramFormatEditor extends DefaultFormatEditor<HistogramFormatEditorParams> {
static formatId = 'histogram';
static formatId = formatId;
state = {
...defaultState,
sampleInputs: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,10 @@
* Side Public License, v 1.
*/

export { HistogramFormatEditor } from './histogram';
import { FieldFormatEditorFactory } from '../types';
import { formatId } from './constants';

export type { HistogramFormatEditor } from './histogram';
export const histogramFormatEditorFactory: FieldFormatEditorFactory = () =>
import('./histogram').then((m) => m.HistogramFormatEditor);
histogramFormatEditorFactory.formatId = formatId;
Loading