[TSVB] Fixes bug with tophit aggregation and index not exist #106814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
reviewed
Jul 27, 2021
src/plugins/vis_type_timeseries/public/application/components/aggs/top_hit.js
Outdated
Show resolved
Hide resolved
…aggs/top_hit.js Co-authored-by: Alexey Antonov <[email protected]>
stratoula
added
Feature:TSVB
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
changed the title
dej611
reviewed
Jul 27, 2021
src/plugins/vis_type_timeseries/public/application/components/aggs/top_hit.js
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
dej611
approved these changes
Jul 28, 2021
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jul 28, 2021
…#106814) * [TSVB] Fixes bug with tophit aggregation and no fields index * Update src/plugins/vis_type_timeseries/public/application/components/aggs/top_hit.js Co-authored-by: Alexey Antonov <[email protected]> * Apply review comments Co-authored-by: Alexey Antonov <[email protected]>
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jul 28, 2021
…#106814) * [TSVB] Fixes bug with tophit aggregation and no fields index * Update src/plugins/vis_type_timeseries/public/application/components/aggs/top_hit.js Co-authored-by: Alexey Antonov <[email protected]> * Apply review comments Co-authored-by: Alexey Antonov <[email protected]>
stratoula
added a commit
that referenced
this pull request
Jul 28, 2021
#106962) * [TSVB] Fixes bug with tophit aggregation and no fields index * Update src/plugins/vis_type_timeseries/public/application/components/aggs/top_hit.js Co-authored-by: Alexey Antonov <[email protected]> * Apply review comments Co-authored-by: Alexey Antonov <[email protected]> Co-authored-by: Alexey Antonov <[email protected]>
stratoula
added a commit
that referenced
this pull request
Jul 28, 2021
#106961) * [TSVB] Fixes bug with tophit aggregation and no fields index * Update src/plugins/vis_type_timeseries/public/application/components/aggs/top_hit.js Co-authored-by: Alexey Antonov <[email protected]> * Apply review comments Co-authored-by: Alexey Antonov <[email protected]> Co-authored-by: Alexey Antonov <[email protected]>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
…#106814) * [TSVB] Fixes bug with tophit aggregation and no fields index * Update src/plugins/vis_type_timeseries/public/application/components/aggs/top_hit.js Co-authored-by: Alexey Antonov <[email protected]> * Apply review comments Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #104695
It fixes a bug on TSVB that occurs only for visualizations that have been created without the index pattern mode (string mode) and the index doesn't exist. This happens only for the top_hit aggregation.
What happens here is that it detects no fields and as a result it crashes. We want to display the "No data" screen.
I added some extra checks to fix it.
How to test it
Insert this SO (from 7.14) and open it. It should not crash and should display "No results found".