[Canvas] Register expression_functions in {expression}/public/plugin.ts.
#106636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuznietsov
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 26, 2021
…in.ts`. (elastic#106636) * Registered `revealImageFunction` in `public/plugin`. * Registered `shapeFunction` in `public/plugin`.
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jul 26, 2021
…in.ts`. (#106636) (#106666) * Registered `revealImageFunction` in `public/plugin`. * Registered `shapeFunction` in `public/plugin`. Co-authored-by: Yaroslav Kuznietsov <[email protected]>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
…in.ts`. (elastic#106636) * Registered `revealImageFunction` in `public/plugin`. * Registered `shapeFunction` in `public/plugin`.
|
No impact on the UI. |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @Kunzetsov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this PR
expression_functionshas been registered atpublic/plugin.tsin addition toserverat further plugins:expression_reveal_imageexpression_shapeTesting Notes
This registers some expression functions on the server side. There is no way to test this as there is nothing that uses the server side functions currently.