-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data][Filters] Move more filter utils to package and cleanup API #106566
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, added a couple minor notes below
@@ -4,6 +4,13 @@ | |||
|
|||
## esFilters variable | |||
|
|||
> Warning: This API is now obsolete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to deprecate this now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be considered a breaking change, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, deprecating something isn't a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the text to "removed"
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @lizozom |
…astic#106566) * Move more utils to package and cleanup API * docs and imports * better imports * change comment Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…06566) (#106988) * Move more utils to package and cleanup API * docs and imports * better imports * change comment Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Liza Katz <[email protected]>
…astic#106566) * Move more utils to package and cleanup API * docs and imports * better imports * change comment Co-authored-by: Kibana Machine <[email protected]>
Summary
Partially addresses #104140
Release Note
The following filter related utilities were marked as deprecated when imported from the data plugin.
Please import them from
@kbn/es-query
.On the client side:
esFilters
is now deprecatedFilterLabel
,FilterItem
,getDisplayValueFromFilter
,generateFilters
,extractTimeRange
can be imported fromdata\public
(not usingesFilters
).@kbn/es-query
COMPARE_ALL_OPTIONS
compareFilters
enableFilter
pinFilter
toggleFilterDisabled
dedupFilters
onlyDisabledFiltersChanged
uniqFilters
8.0
public APIconvertRangeFilterToTimeRangeString
extractTimeFilter
changeTimeFilter
mapAndFlattenFilters
On the server side:
esFilters
is now deprecated@kbn/es-query
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers