[ML] Fix Anomaly Explorer annotations misaligned #105696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
added
bug
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Jul 15, 2021
x-pack/plugins/ml/public/application/explorer/swimlane_data_utils.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/explorer/swimlane_data_utils.ts
Outdated
Show resolved
Hide resolved
|
Not related to the changes here, but in the Single Metric Viewer the annotations lane extends to the end of the right hand brush handle, and isn't aligned to the end of the chart area, as it is on the left hand side.
|
peteharverson
approved these changes
Jul 15, 2021
@peteharverson Thanks for testing. I also added a quick fix for it here. Before
After |
darnautov
reviewed
Jul 15, 2021
x-pack/plugins/ml/public/application/services/anomaly_timeline_service.ts
Outdated
Show resolved
Hide resolved
qn895
added
the
auto-backport
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @qn895 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 15, 2021
* Move swimlane annotation out of container, add new axis width prop * [ML] Fix alignment if some annotations overflow * [ML] Move utils function to inside anomaly_timeline_service * [ML] Fix y chart overflow * [ML] Enforce stricter check on isOverallSwimlaneData * [ML] Update logic to check if only one label
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 15, 2021
* Move swimlane annotation out of container, add new axis width prop * [ML] Fix alignment if some annotations overflow * [ML] Move utils function to inside anomaly_timeline_service * [ML] Fix y chart overflow * [ML] Enforce stricter check on isOverallSwimlaneData * [ML] Update logic to check if only one label
kibanamachine
added a commit
that referenced
this pull request
Jul 15, 2021
* Move swimlane annotation out of container, add new axis width prop * [ML] Fix alignment if some annotations overflow * [ML] Move utils function to inside anomaly_timeline_service * [ML] Fix y chart overflow * [ML] Enforce stricter check on isOverallSwimlaneData * [ML] Update logic to check if only one label Co-authored-by: Quynh Nguyen <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 16, 2021
* Move swimlane annotation out of container, add new axis width prop * [ML] Fix alignment if some annotations overflow * [ML] Move utils function to inside anomaly_timeline_service * [ML] Fix y chart overflow * [ML] Enforce stricter check on isOverallSwimlaneData * [ML] Update logic to check if only one label Co-authored-by: Quynh Nguyen <[email protected]>
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes annotations being misaligned in the Anomaly Explorer view.
Before
After
