[APM] Fixes support for APM index pattern with data streams #105360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogupte
added
release_note:skip
nreese
reviewed
Jul 12, 2021
| @@ -39,7 +39,7 @@ import { getDefaultDynamicProperties } from '../../../styles/vector/vector_style | |||
|
|
|||
| // redefining APM constant to avoid making maps app depend on APM plugin | |||
| export const APM_INDEX_PATTERN_ID = 'apm_static_index_pattern_id'; | |||
| export const APM_INDEX_PATTERN_TITLE = 'apm-*'; | |||
| export const APM_INDEX_PATTERN_TITLE = 'traces-apm*,logs-apm*,metrics-apm*,apm-*'; | |||
There was a problem hiding this comment.
I think this use of APM_INDEX_PATTERN_TITLE is going to need to be updated with this change, https://github.com/elastic/kibana/blob/master/x-pack/plugins/maps/public/classes/layers/solution_layers/security/create_layer_descriptors.ts#L38
There was a problem hiding this comment.
I've updated the test with the new labels based on the index pattern title. Is there any other the new pattern should be handled?
- tests each component of index pattern title for index matches This reverts commit a3a27df.
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ogupte
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2021
…105360) * [APM] Fixes support for APM index pattern with data streams (elastic#94702) * fix unit test * - Revert "fix unit test" - tests each component of index pattern title for index matches This reverts commit a3a27df.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2021
…105360) * [APM] Fixes support for APM index pattern with data streams (elastic#94702) * fix unit test * - Revert "fix unit test" - tests each component of index pattern title for index matches This reverts commit a3a27df.
6 tasks
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2021
…#105535) * [APM] Fixes support for APM index pattern with data streams (#94702) * fix unit test * - Revert "fix unit test" - tests each component of index pattern title for index matches This reverts commit a3a27df. Co-authored-by: Oliver Gupte <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2021
…#105536) * [APM] Fixes support for APM index pattern with data streams (#94702) * fix unit test * - Revert "fix unit test" - tests each component of index pattern title for index matches This reverts commit a3a27df. Co-authored-by: Oliver Gupte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #94702.
Fixes maps support for the APM data streams, which would contain geo data of traces if a user migrates in the APM settings (#102682, #105015).