Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement interactiveSetup plugin server side functionality: setup layout #105222

Merged
merged 4 commits into from
Aug 3, 2021
Merged

Implement interactiveSetup plugin server side functionality: setup layout #105222

merged 4 commits into from
Aug 3, 2021

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Jul 12, 2021 •
edited
Loading

Summary

Step №2 in implementing interactiveSetup plugin server side functionality: a base layout for setup method (config, routes, etc.).

The plugin isn't functional yet and hence disabled by default, the goal is to incrementally review and merge pieces of the functionality.

No tests yet, as there is still nothing to test, but we'll cover everything before alpha2.

Part of : #104068

@azasypkin azasypkin added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes labels Jul 12, 2021
This was referenced Jul 12, 2021
Closed
Merged
@azasypkin azasypkin force-pushed the issue-104068-interactive-setup branch from 2325d79 to 70a0a84 Compare July 20, 2021 09:54
@azasypkin azasypkin force-pushed the issue-104068-interactive-setup branch from 70a0a84 to 669955b Compare July 29, 2021 15:15
@azasypkin azasypkin changed the title Implement userSetup plugin server side functionality. Implement interactiveSetup plugin server side functionality. Aug 2, 2021
@azasypkin azasypkin force-pushed the issue-104068-interactive-setup branch from 669955b to bc0c536 Compare August 2, 2021 06:45
@azasypkin azasypkin changed the title Implement interactiveSetup plugin server side functionality. Implement interactiveSetup plugin server side functionality: setup layout Aug 2, 2021
@azasypkin azasypkin removed the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Aug 2, 2021
@azasypkin azasypkin force-pushed the issue-104068-interactive-setup branch from bc0c536 to 7c340eb Compare August 2, 2021 06:56
@azasypkin azasypkin requested a review from thomheymann August 2, 2021 07:38
@azasypkin
Copy link
Member Author

azasypkin commented Aug 2, 2021 •
edited
Loading

@thomheymann I think this PR is ready for the initial feedback whenever you have time. Let me know what else you'd like me to include in this PR that may be useful for your work in #106881

thomheymann
thomheymann approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
interactiveSetup - 5 +5
userSetup 5 - -5
total -0

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
interactiveSetup - 3.5KB +3.5KB
userSetup 3.4KB - -3.4KB
total +28.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin marked this pull request as ready for review August 3, 2021 05:31
@azasypkin azasypkin requested review from a team as code owners August 3, 2021 05:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

jbudz
jbudz approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limits.yml LGTM

@azasypkin azasypkin added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes labels Aug 3, 2021
@azasypkin azasypkin merged commit ed28155 into elastic:master Aug 3, 2021
@azasypkin azasypkin deleted the issue-104068-interactive-setup branch August 3, 2021 13:52
@azasypkin azasypkin added backport:skip This commit does not require backporting and removed v7.15.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 3, 2021
@elastic elastic deleted a comment from kibanamachine Aug 3, 2021
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@azasypkin @vadimkibana
Implement interactiveSetup plugin server side functionality: `setup…
2ff8327 
…` layout (elastic#105222)
@azasypkin azasypkin self-assigned this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@thomheymann thomheymann thomheymann approved these changes

Assignees

@azasypkin azasypkin

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azasypkin @kibanamachine @elasticmachine @thomheymann @jbudz