[ML] Fix Single Metric Viewer & Explorer annotation table actions overflow and annotations count not matching #104955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
added
bug
|
Pinging @elastic/ml-ui (:ml) |
|
jenkins, test this (had to abort for Jenkins upgrade) |
qn895
changed the title
qn895
changed the title
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @qn895 |
qn895
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2021
…rflow and annotations count not matching (elastic#104955) * Fix annotations * Fix translations * Fix onclick open * Fix label/aggregations mismatch * Fix title
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2021
…rflow and annotations count not matching (elastic#104955) * Fix annotations * Fix translations * Fix onclick open * Fix label/aggregations mismatch * Fix title
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2021
…rflow and annotations count not matching (#104955) (#105140) * Fix annotations * Fix translations * Fix onclick open * Fix label/aggregations mismatch * Fix title Co-authored-by: Quynh Nguyen <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2021
…rflow and annotations count not matching (#104955) (#105141) * Fix annotations * Fix translations * Fix onclick open * Fix label/aggregations mismatch * Fix title Co-authored-by: Quynh Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a regression introduced by #101236 which causes the labels to overlap in the Explorer/Single Metric View. The disabled option was also still clickable, which leads to an unsupported page.
Before
After
Annotations table in the Explorer view
Annotations table in the job list
When Single Metric Viewer view is disabled
Also fixes #98074 by indicating more clearly that we are only showing 500 annotations.
Checklist
Delete any items that are not applicable to this PR.