Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional old SO type from 7.6 to filter and test #104913

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Jul 8, 2021

Summary

This adds the no longer used server SO type to the list of types we exclude from upgrade migrations. This type was previously used to store the UUID of the server but is no longer in use.

Related to #104690

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@joshdover joshdover added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0 v7.15.0 v8.0.0 labels Jul 8, 2021
@joshdover joshdover marked this pull request as ready for review July 8, 2021 16:20
@joshdover joshdover requested a review from a team as a code owner July 8, 2021 16:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@joshdover joshdover added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 8, 2021
@joshdover joshdover enabled auto-merge (squash) July 8, 2021 16:20
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.14 Commit could not be cherrypicked due to conflicts
7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 104913

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
joshdover added a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2021
@joshdover
Copy link
Contributor Author

7.14 backport added to #104859

@joshdover joshdover deleted the migrations/add-server-type branch July 9, 2021 11:27
kibanamachine added a commit that referenced this pull request Jul 9, 2021
…4859)

* Add test for detecting new and removed SO types (#104507)

* Remove type not present on 7.14 branch

* Add additional old SO type from 7.6 to filter and test (#104913)

Co-authored-by: Josh Dover <[email protected]>
joshdover added a commit that referenced this pull request Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants