Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Fix recent cases filter #104826

Merged
merged 2 commits into from
Jul 8, 2021
Merged

[Cases] Fix recent cases filter #104826

merged 2 commits into from
Jul 8, 2021

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jul 8, 2021 •
edited
Loading

Summary

This PR fixes a bug where when changing tabs on the recent cases widget the reporter filter is preserved between them when it should not. The first tab shows recent cases from all users. The second tab shows recent cases of the current user. If you click on the "my recent cases" tab the reporter of the filter changes to the current user. If you click back to the "recent cases" tab the reporter is preserved.

Addresses: #102321

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0 v7.15.0 8.0.0 labels Jul 8, 2021
@cnasikas cnasikas self-assigned this Jul 8, 2021
@cnasikas cnasikas requested a review from a team as a code owner July 8, 2021 09:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@cnasikas cnasikas mentioned this pull request Jul 8, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 528.2KB 528.2KB +12.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

semd
semd approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnasikas cnasikas merged commit 98750a3 into elastic:master Jul 8, 2021
@cnasikas cnasikas deleted the 102321 branch July 8, 2021 11:29
This was referenced Jul 8, 2021
Merged
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request Jul 8, 2021
@cnasikas
[Cases] Fix recent cases filter (elastic#104826)
9b80411
cnasikas added a commit that referenced this pull request Jul 8, 2021
@cnasikas
[Cases] Fix recent cases filter (#104826) (#104845)
0562f40
cnasikas added a commit that referenced this pull request Jul 8, 2021
@cnasikas
[Cases] Fix recent cases filter (#104826) (#104846)
672a3dd
@timroes timroes added v8.0.0 and removed 8.0.0 labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

Assignees

@cnasikas cnasikas

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cnasikas @elasticmachine @kibanamachine @semd @timroes