Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing annotations table loading hang #104825

Merged
merged 1 commit into from
Jul 9, 2021
Merged

[ML] Fixing annotations table loading hang #104825

merged 1 commit into from
Jul 9, 2021

Conversation

jgowdyelastic
Copy link
Member

Fixes issue where annotations table fails to load if the job hasn't been run.

Before
image

After
image

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review release_note:fix :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 8, 2021
@jgowdyelastic jgowdyelastic self-assigned this Jul 8, 2021
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 8, 2021 09:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this pull request Jul 8, 2021
Closed
25 tasks
peteharverson
peteharverson approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +57.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

walterra
walterra approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jgowdyelastic jgowdyelastic merged commit d4e46c5 into elastic:master Jul 9, 2021
@jgowdyelastic jgowdyelastic deleted the fix-annotations-spinner-hang branch July 9, 2021 07:13
@kibanamachine kibanamachine mentioned this pull request Jul 9, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2021
@jgowdyelastic @kibanamachine
[ML] Fixing annotations table loading hang (elastic#104825)
c12227c
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2021
@jgowdyelastic @kibanamachine
[ML] Fixing annotations table loading hang (elastic#104825)
d2f3bc0
@kibanamachine kibanamachine mentioned this pull request Jul 9, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 9, 2021
@kibanamachine @jgowdyelastic
[ML] Fixing annotations table loading hang (#104825) (#105020)
9fa2827 
Co-authored-by: James Gowdy <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 9, 2021
@kibanamachine @jgowdyelastic
[ML] Fixing annotations table loading hang (#104825) (#105021)
aeb6336 
Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @peteharverson