Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Fix inspect button on host details page #104011

Merged
merged 6 commits into from
Jul 5, 2021

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Jun 30, 2021

Summary

#101867

Steps to Reproduce:

  1. Navigate to 'Host' tab under Security App.
  2. Scroll down and click on any of the Host Name. Notice that user is navigated to Host detail page.
  3. Now, click on 'Inspect Icon' displayed for Host details section.
  4. Observe that 'Inspect Icon' is not functional.

Expected Result:
'Inspect Icon' should be functional and Inspect modal window should be popped up to the user.

Checklist

@angorayc angorayc added Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v7.15.0 v8.0.0 labels Jun 30, 2021
@angorayc angorayc added the bug Fixes for quality problems that affect the customer experience label Jun 30, 2021
@angorayc angorayc marked this pull request as ready for review July 1, 2021 08:51
@angorayc angorayc requested a review from a team as a code owner July 1, 2021 08:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@angorayc angorayc added the release_note:skip Skip the PR/issue when compiling release notes label Jul 1, 2021
@angorayc
Copy link
Contributor Author

angorayc commented Jul 1, 2021

@elasticmachine merge upstream

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM.
Testing it manually the inspect modal is displayed correctly:
Captura de Pantalla 2021-07-01 a les 17 25 40
🚀

@angorayc
Copy link
Contributor Author

angorayc commented Jul 5, 2021

@elasticmachine merge upstream

@angorayc angorayc enabled auto-merge (squash) July 5, 2021 09:20
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.3MB 6.3MB +65.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit e5954a6 into elastic:master Jul 5, 2021
angorayc added a commit to angorayc/kibana that referenced this pull request Jul 5, 2021
…04011)

* add test

* rename test

* update snapshot

Co-authored-by: Kibana Machine <[email protected]>
angorayc added a commit to angorayc/kibana that referenced this pull request Jul 5, 2021
…04011)

* add test

* rename test

* update snapshot

Co-authored-by: Kibana Machine <[email protected]>
angorayc added a commit that referenced this pull request Jul 5, 2021
…104285)

* add test

* rename test

* update snapshot

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
angorayc added a commit that referenced this pull request Jul 5, 2021
…104286)

* add test

* rename test

* update snapshot

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants