[Snapshot + Restore] Fix error handling for repositories API #103723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
v8.0.0
Team:Kibana Management
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
cjcenizal
approved these changes
Jun 30, 2021
| import type { | ||
| SnapshotGetRepositoryResponse, | ||
| SnapshotRepositorySettings, | ||
| } from '@elastic/elasticsearch/api/types'; |
There was a problem hiding this comment.
+++++++++++++++++++++++++++
cjcenizal
added
the
auto-backport
|
Merging now to make FF |
💔 Backport failed
To backport manually run: |
|
Thanks @cjcenizal! Re: backport failure. I think we might need to wait for #103693 to be merged into 7.x first. I was hitting issues with CI earlier, but hopefully this next run should be green 🤞 . |
|
Backport PR: #103814 |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
alisonelizabeth
added a commit
that referenced
this pull request
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103673
This appears to be a regression that only made it to master, although it will now need to be backported to align with the work done in #103331. There was a test that checked it, but it was not set up correctly and was falsely passing.
To manually test, you can stub the ES snapshots API request so that it will fail (quickest/easiest), or you can set up a failed repository with snapshots to trigger an actual error. This involves manually altering the
index-Nfile in your local repository so that it becomes invalid. The repository details panel should still show, but without the snapshot count.