[App Search] Updated copy for Precision Slider step descriptions #103684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byronhulcher
added
release_note:skip
byronhulcher
commented
Jun 29, 2021
| @@ -59,11 +60,14 @@ describe('PrecisionSlider', () => { | |||
|
|
|||
| describe('Step Description', () => { | |||
| it('is visible when there is a step description', () => { | |||
| setMockValues({ ...MOCK_VALUES, precision: 10 }); | |||
There was a problem hiding this comment.
setting precision instead of searchSettings.precision meant that this setMockValues wasn't actually doing anything and searchSettings.precision remained at the value 2
| rerender(wrapper); | ||
|
|
||
| expect(wrapper.find('[data-test-subj="StepDescription"]').render().text()).toEqual( | ||
| 'Default. High recall, low precision.' |
There was a problem hiding this comment.
Luckily(????) I had used the default text (step 2) instead of the description text for step 10 here.
|
Thanks @constancecchen I've enabled auto-merge! |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
tylersmalley
pushed a commit
that referenced
this pull request
Jun 29, 2021
… | [App Search] Updated copy for Precision Slider step descriptions (#103684) (#103767) * [App Search] New Precision Slider for Relevance Tuning (#103015) * Precision is now a required param for search settings * Made RelevanceTuningLogic aware of precision param * New PrecisionSlider component * Add PrecisionSlider to RelevanceTuning * Fix types in test * Fix imports for PrecisionSlider * Slight panel and text adjustments. * Comment out docs link * Add commented out test for docs * Can we just all agree not to talk about this commit * Restore docs link * Fix docs link again * Clean-up step description logic * Test for documentation link * Moving the spacer to align titles. * Missing test for updatePrecision * Fix CSS for step description * Remove containing EuiPanel * Improve screen reader experience Co-authored-by: Davey Holler <[email protected]> * [App Search] Updated copy for Precision Slider step descriptions (#103684) * Update precision slider description copy * Fixed a broken (but passing) test Co-authored-by: Byron Hulcher <[email protected]> Co-authored-by: Davey Holler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates copy based on external discussions. Also fixes a test which was broken but managed to pass because of the specific
expect()I wrote. Please reference the issue linked below for the expected copy changes.Checklist
Delete any items that are not applicable to this PR.