-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when validating the form with non blocking validations #103629
Fix error when validating the form with non blocking validations #103629
Conversation
src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.test.tsx
Show resolved
Hide resolved
5a7e071
to
42bda1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the fix for this @machadoum ! Looks great, I made a few comments in the code cheers 👍
src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.test.tsx
Show resolved
Hide resolved
src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.test.tsx
Outdated
Show resolved
Hide resolved
src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.test.tsx
Show resolved
Hide resolved
src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.test.tsx
Outdated
Show resolved
Hide resolved
42bda1d
to
9cf3d17
Compare
src/plugins/es_ui_shared/static/forms/components/fields/combobox_field.tsx
Outdated
Show resolved
Hide resolved
6a5d15c
to
e8fb07d
Compare
e8fb07d
to
b165157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the contribution @machadoum ! I think now it works as expected 👍
@elasticmachine merge upstream |
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @machadoum |
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (292 commits) bring back KQL autocomplete in timeline + fix last updated (elastic#105380) [Maps] Change TOC pop-up wording to reflect filter change, not search bar change (elastic#105163) Updating urls to upstream elastic repo (elastic#105250) [Maps] Move new vector layer wizard card down (elastic#104797) Exclude registering the cases feature if not enabled (elastic#105292) [Uptime] Alerts - Monitor status alert - check monitor status by monitor.timespan (elastic#104541) updated UI copy (elastic#105184) Log a warning when documents of unknown types are detected during migration (elastic#105213) [Logs UI] Register log threshold rule as lifecycle rule (elastic#104341) [Ingest pipelines] add network direction processor (elastic#103436) [Console] Autocomplete definitions (manual backport) (elastic#105086) [Security Solution] User can make Exceptions for Memory protection alerts (elastic#102196) [Lens] Formula: add validation for multiple field/metrics (elastic#104092) Removing async from file upload and data visualizer plugins start lifecycle (elastic#105197) Fix error when validating the form with non blocking validations (elastic#103629) [ML] Fix "View by" swim lane with applied filter and sorting by score (elastic#105217) Update dependency @elastic/charts to v32 (elastic#104625) [CTI] shortens large numbers on Dashboard Link Panel (elastic#105269) [Security Solution][Endpoint][Host Isolation] Fixes bug to remove excess host metadata status toasts on non user initiated errors (elastic#105331) [Cases] Fix pushing alerts count on every push to external service (elastic#105030) ... # Conflicts: # x-pack/plugins/reporting/common/types.ts
…stic#103629) * Fix error when validating the form with non blocking validations issue: elastic#102338 * Add a flag to only validate blocking validation when validating the form * Refactor bypass validation Co-authored-by: Sébastien Loix <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
…3629) (#105478) * Fix error when validating the form with non blocking validations issue: #102338 * Add a flag to only validate blocking validation when validating the form * Refactor bypass validation Co-authored-by: Sébastien Loix <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Sébastien Loix <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
@sebelga Should this be backported to 7.14? |
I don't think so this was not critical and an enhancement in a security form. @machadoum correct me if I'm wrong. |
I agree with @sebelga. It is a small improvement. |
issue: #102338
Summary
Change
validationType
default value ofvalidate()
function onuse_field.ts
file. This change makes sure that ArrayItem validations are ignored when theform.validate()
is called.I added tests for the form validation and also for field validation with different values for
isBlocking
.Checklist