[Es query] Move to package #103530
Merged
[Es query] Move to package #103530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
June 23, 2021 23:08
3 tasks
added 2 commits
June 30, 2021 16:20
lizozom
added
the
auto-backport
added 3 commits
July 19, 2021 17:45
joshdover
suggested changes
Jul 19, 2021
added 3 commits
July 19, 2021 20:41
joshdover
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Approving to clear the codeowners for Core team (which is only a newline that could be removed). I haven't reviewed the code in depth, but the new package looks ✅ for our consumption of the library in Saved Objects to unblock the Bazel project. Thanks for doing this work, @lizozom!
| @@ -33,7 +33,6 @@ import { errors as EsErrors } from '@elastic/elasticsearch'; | |||
| const { nodeTypes } = esKuery; | |||
|
|
|||
| jest.mock('./search_dsl/search_dsl', () => ({ getSearchDsl: jest.fn() })); | |||
|
|
|||
There was a problem hiding this comment.
nit: we could probably put this back, but doesn't really matter.
timroes
approved these changes
Jul 20, 2021
added 4 commits
July 21, 2021 13:39
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 21, 2021
May the forces of bootstrapping helps us 🙏🏻 😉
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jul 21, 2021
May the forces of bootstrapping helps us 🙏🏻 😉 Co-authored-by: Liza Katz <[email protected]>
1 task
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_view_mode·js.dashboard mode Dashboard View Mode Dashboard viewer "before all" hook: Create dashboard only mode user for "shows only the dashboard app link"Standard OutStack TraceKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·js.security app users should show the default rolesStandard OutStack TraceKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·js.security app users should show the default rolesStandard OutStack Traceand 4 more failures, only showing the first 3. Metrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @lizozom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #51659
Resolves #17284
Partially addresses #84788
Need for #55485
Overview
This PR turned out rather big (even after multiple preliminary PRs).
These are the changes included:
es_querycode to a new packagetitletoIndexPatternBasepublicandserverand mark them asdepreceatedcommonor using deep importsbazelbuild for package (Thanks @mistic), including using a newpeggybuild.kuery/grammarin jest testsPlugin API changes
Moving some key types and functions related to query generation to a package.
The following types and functions should be imported from
@kbn/es-query. Importing them from thedataplugin is now deprecated and support will be removed inv8.0:dataplugin)IndexPatternBaseIndexPatternFieldBaseIFieldSubTypeRangeFilterRangeFilterMetaRangeFilterParamsExistsFilterPhrasesFilterPhraseFilterCustomFilterMatchAllFilterisExistsFilterisFilterPinnedisMatchAllFilterisMissingFilterisPhraseFilterisPhrasesFilterisQueryStringFilterisRangeFilterbuildEmptyFilterbuildExistsFilterbuildPhraseFilterbuildPhrasesFilterbuildQueryFilterbuildRangeFiltergetPhraseFilterFieldgetPhraseFilterValuetoggleFilterNegateddisableFilterKueryNodefromKueryExpressiontoElasticsearchQuerynodeTypesbuildEsQuerybuildQueryFromFiltersluceneStringToDsldecorateQueryEsQueryConfigChecklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers