Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on kibana-ui-framework repo. #10281

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Remove dependency on kibana-ui-framework repo. #10281

merged 1 commit into from
Feb 13, 2017

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Feb 10, 2017 •
edited by pickypg
Loading

Forgot to remove this as part of #9192

This also addresses the error when running uiFramework:start:

ERROR in ./ui_framework/doc_site/src/index.js
Module build failed: SyntaxError: C:/dev/elastic/kibana/ui_framework/doc_site/src/index.js: Unexpected token (73:2)

  71 |
  72 | ReactDOM.render(
> 73 |   <Provider store={store}>
     |   ^
  74 |     <Router
  75 |       history={history}
  76 |       routes={routes}```

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. chore v5.4.0 v6.0.0 labels Feb 10, 2017
pickypg
pickypg approved these changes Feb 13, 2017
View reviewed changes
Copy link
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally

@cjcenizal cjcenizal merged commit 2563d88 into elastic:master Feb 13, 2017
@cjcenizal cjcenizal deleted the improvement/remove-external-ui-framework-dependency branch February 13, 2017 18:42
elastic-jasper added a commit that referenced this pull request Feb 13, 2017
@elastic-jasper
Remove dependency on kibana-ui-framework repo.
f428c9e 
Backports PR #10281

**Commit 1:**
Remove dependency on kibana-ui-framework repo.

* Original sha: d81e768
* Authored by CJ Cenizal <[email protected]> on 2017-02-10T00:17:00Z
@elastic-jasper elastic-jasper mentioned this pull request Feb 13, 2017
Merged
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Feb 13, 2017
@cjcenizal
Remove dependency on kibana-ui-framework repo. (elastic#10281)
ad3a600
@cjcenizal cjcenizal mentioned this pull request Feb 13, 2017
Merged
cjcenizal added a commit that referenced this pull request Feb 13, 2017
@cjcenizal
Remove dependency on kibana-ui-framework repo. (#10281) (#10318)
bf2eb68
epixa pushed a commit that referenced this pull request Feb 14, 2017
@elastic-jasper @epixa
Remove dependency on kibana-ui-framework repo. (#10317)
7b7430d 
Backports PR #10281

**Commit 1:**
Remove dependency on kibana-ui-framework repo.

* Original sha: d81e768
* Authored by CJ Cenizal <[email protected]> on 2017-02-10T00:17:00Z
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Feb 28, 2017
@cjcenizal
Remove dependency on kibana-ui-framework repo. (elastic#10281)
b05876e
@cjcenizal cjcenizal mentioned this pull request Feb 28, 2017
Merged
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Feb 28, 2017
@cjcenizal
Remove dependency on kibana-ui-framework repo. (elastic#10281)
d4354a6
@cjcenizal cjcenizal mentioned this pull request Feb 28, 2017
Merged
cjcenizal added a commit that referenced this pull request Mar 2, 2017
@cjcenizal
Remove dependency on kibana-ui-framework repo. (#10281) (#10609)
3af4a26
cjcenizal added a commit that referenced this pull request Mar 2, 2017
@cjcenizal
Remove dependency on kibana-ui-framework repo. (#10281) (#10610)
65a19b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickypg pickypg pickypg approved these changes

@tylersmalley tylersmalley Awaiting requested review from tylersmalley

Assignees
No one assigned
Labels
chore Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.4.0 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcenizal @pickypg