[Security Solutions] Management navigation #102685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… security-navigation-sergi
… security-navigation-sergi
|
@elasticmachine merge upstream |
…emd/kibana into security-navigation-management
semd
changed the title
pgayvallet
approved these changes
Jun 22, 2021
dasansol92
approved these changes
Jun 22, 2021
dasansol92
reviewed
Jun 22, 2021
angorayc
reviewed
Jun 22, 2021
| @@ -166,26 +167,56 @@ export const createAppRootMockRenderer = (): AppContextTestRender => { | |||
| }; | |||
| }; | |||
|
|
|||
| const createCoreStartMock = (): ReturnType<typeof coreMock.createStart> => { | |||
| const createCoreStartMock = ( | |||
There was a problem hiding this comment.
I found that I need the same fix for unit tests in my PR, but I don't have the change in management, so I just did some mock in my PR to pass the test. Please be ware of this when merging this.
…ibana into security-navigation-sergi
angorayc
reviewed
Jun 22, 2021
| : getUrlForApp(`${APP_ID}:${id}`, { | ||
| path: urlSearch, | ||
| }); | ||
| const primaryNavigationItems = useMemo( |
There was a problem hiding this comment.
I'm thinking moving this to x-pack/plugins/security_solution/public/app/home/home_navigations.tsx as an independent configs, like
export const PrimaryNavigationItems = [
{
id: APP_ID,
name: '',
items: [
navTabs.overview,
// TODO: [1101] Move the following nav items to its group
navTabs.detections,
navTabs.hosts,
navTabs.network,
navTabs.timelines,
navTabs.case,
],
},
{
...navTabGroups.detect,
items: [
// navTabs.alert,
// navTabs.rule,
// navTabs.exception,
],
},
{
...navTabGroups.explore,
items: [],
},
{
...navTabGroups.investigate,
items: [],
},
{
...navTabGroups.manage,
items: [navTabs.endpoints, navTabs.trusted_apps, navTabs.event_filters],
},
];
and in here we could import it and do
const primaryNavigationItems = useMemo(
() =>
PrimaryNavigationItems.map((item) => ({
...item,
items: item.items.map((t: NavTab) => getSideNav(t)),
})),
[getSideNav]
);
angorayc
approved these changes
Jun 23, 2021
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / jest / Jest Tests.x-pack/plugins/security_solution/public/overview/pages.Overview rendering it does NOT render the Endpoint banner when the endpoint index is available AND storage is setStandard OutStack TraceKibana Pipeline / jest / Jest Tests.x-pack/plugins/security_solution/public/overview/pages.Overview rendering when no index is available renders the Setup Instructions textStandard OutStack TraceKibana Pipeline / jest / Jest Tests.x-pack/plugins/security_solution/public/overview/pages.Overview rendering when no index is available does not show Endpoint get ready button when ingest is not enabledStandard OutStack Traceand 10 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
michaelolo24
pushed a commit
to michaelolo24/kibana
that referenced
this pull request
Jun 23, 2021
* prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * breadcrumbs changes and sidenav generation improvements * jest tests for breadcrumbs and navigation changes * retrocompatibility for sections that are not yet migrated to deepLinks * management deepLinks and plugin refactoring * home navigation changes * management navigation migrated to deeplinks * jest tests fixed * header page back link improved and tests fixed * type errors fixes * improve home navigation encapsulation Co-authored-by: Kibana Machine <[email protected]>
XavierM
pushed a commit
that referenced
this pull request
Jun 24, 2021
* prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * breadcrumbs changes and sidenav generation improvements * jest tests for breadcrumbs and navigation changes * retrocompatibility for sections that are not yet migrated to deepLinks * management deepLinks and plugin refactoring * home navigation changes * management navigation migrated to deeplinks * jest tests fixed * header page back link improved and tests fixed * type errors fixes * improve home navigation encapsulation Co-authored-by: Kibana Machine <[email protected]>
semd
added a commit
that referenced
this pull request
Jun 29, 2021
* [SecuritySolutions] [Navigation] Prepare new routing and migrate overview (#101733) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * [Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation (#102306) * Update navigateToApp and getUrlForApp to provide the deepLinkId * Update Hosts and Network routes to start from /hosts and /network * Add Hosts and Network to side nav menu under "Explore" menu group * Delete Hosts and Network old menu code * Fix broken tests * [SecuritySolution] Add detections subplugin to deeplink (#101791) * prepare new routing and migrate overview * init nav deeplink * split detections into rules and alerts * init exception link * init detections * link to rules creation page * link to rules creation page * rename detections to alerts * fix unit tests * fix rules creation page * remove console * fix lint error * fix unit tests * fix unit tests * isolating rules and exceptions page * replace history push with navigateToApp * fix unit test * temporary fix for createCoreStartMock * update cypress * skip failing cypress * skip failing cypress Co-authored-by: semd <[email protected]> * Migrate "Investigate" tab group to new side navigation (#102705) * Migrate "Investigate" tab group to new side navigation It includes: * Timelines * Cases * Quick fix useFormatUrl and HeaderPage navigation * [Security Solutions] Management navigation (#102685) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * breadcrumbs changes and sidenav generation improvements * jest tests for breadcrumbs and navigation changes * retrocompatibility for sections that are not yet migrated to deepLinks * management deepLinks and plugin refactoring * home navigation changes * management navigation migrated to deeplinks * jest tests fixed * header page back link improved and tests fixed * type errors fixes * improve home navigation encapsulation Co-authored-by: Kibana Machine <[email protected]> * Fix type checking * export header page * fix padding * add redirect routes * unskip detection cypress * fix i18n * fix create your own rules btn * fix cancel button on rules creation page * test fixes * fix breadcrumbs for rules pages * unit test fixes * additional fixes * [Security Solutions] Navigation usage tracker and general changes (#103271) * [Security Solutions] use of currentAppId$ migrated. and some small fixes * unused constants removed * remove unused constant * test fix and types * fix cypress * fix cypress tests * Fix case navTab permission and tests * Revert 'timeline.isOpen' breadcrumb code that was deleted during merge * Fix useInsertTimeline test by removing '/' * change global navigation visible deeplinks * fix /admininstration top level redirect to * fix global search icon, nav order and overview hosts link * update start a new case link * fix rules link in exception list table * unskip cypress tests * update rules link * fix full screen timeline * fixing broken links and administration telemetry split * remove unused comments * remove timeline z-index and cleanup global header component * some minor fixes * add unit tests for detections breadcrumbs * remove case to global/search nav when cases is none * rename test scenario * fix side_panel flyout * fix cases use cases between search/gobal nav * timeline snapshot regenerated and cypres test fixed * rollback management tracking split as it causes unexpected errors on the telemetry component Co-authored-by: Pablo Machado <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Michael Olorunnisola <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]>
semd
added a commit
to semd/kibana
that referenced
this pull request
Jun 29, 2021
* [SecuritySolutions] [Navigation] Prepare new routing and migrate overview (elastic#101733) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * [Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation (elastic#102306) * Update navigateToApp and getUrlForApp to provide the deepLinkId * Update Hosts and Network routes to start from /hosts and /network * Add Hosts and Network to side nav menu under "Explore" menu group * Delete Hosts and Network old menu code * Fix broken tests * [SecuritySolution] Add detections subplugin to deeplink (elastic#101791) * prepare new routing and migrate overview * init nav deeplink * split detections into rules and alerts * init exception link * init detections * link to rules creation page * link to rules creation page * rename detections to alerts * fix unit tests * fix rules creation page * remove console * fix lint error * fix unit tests * fix unit tests * isolating rules and exceptions page * replace history push with navigateToApp * fix unit test * temporary fix for createCoreStartMock * update cypress * skip failing cypress * skip failing cypress Co-authored-by: semd <[email protected]> * Migrate "Investigate" tab group to new side navigation (elastic#102705) * Migrate "Investigate" tab group to new side navigation It includes: * Timelines * Cases * Quick fix useFormatUrl and HeaderPage navigation * [Security Solutions] Management navigation (elastic#102685) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * breadcrumbs changes and sidenav generation improvements * jest tests for breadcrumbs and navigation changes * retrocompatibility for sections that are not yet migrated to deepLinks * management deepLinks and plugin refactoring * home navigation changes * management navigation migrated to deeplinks * jest tests fixed * header page back link improved and tests fixed * type errors fixes * improve home navigation encapsulation Co-authored-by: Kibana Machine <[email protected]> * Fix type checking * export header page * fix padding * add redirect routes * unskip detection cypress * fix i18n * fix create your own rules btn * fix cancel button on rules creation page * test fixes * fix breadcrumbs for rules pages * unit test fixes * additional fixes * [Security Solutions] Navigation usage tracker and general changes (elastic#103271) * [Security Solutions] use of currentAppId$ migrated. and some small fixes * unused constants removed * remove unused constant * test fix and types * fix cypress * fix cypress tests * Fix case navTab permission and tests * Revert 'timeline.isOpen' breadcrumb code that was deleted during merge * Fix useInsertTimeline test by removing '/' * change global navigation visible deeplinks * fix /admininstration top level redirect to * fix global search icon, nav order and overview hosts link * update start a new case link * fix rules link in exception list table * unskip cypress tests * update rules link * fix full screen timeline * fixing broken links and administration telemetry split * remove unused comments * remove timeline z-index and cleanup global header component * some minor fixes * add unit tests for detections breadcrumbs * remove case to global/search nav when cases is none * rename test scenario * fix side_panel flyout * fix cases use cases between search/gobal nav * timeline snapshot regenerated and cypres test fixed * rollback management tracking split as it causes unexpected errors on the telemetry component Co-authored-by: Pablo Machado <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Michael Olorunnisola <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]>
semd
added a commit
that referenced
this pull request
Jun 29, 2021
* [SecuritySolutions] [Navigation] Prepare new routing and migrate overview (#101733) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * [Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation (#102306) * Update navigateToApp and getUrlForApp to provide the deepLinkId * Update Hosts and Network routes to start from /hosts and /network * Add Hosts and Network to side nav menu under "Explore" menu group * Delete Hosts and Network old menu code * Fix broken tests * [SecuritySolution] Add detections subplugin to deeplink (#101791) * prepare new routing and migrate overview * init nav deeplink * split detections into rules and alerts * init exception link * init detections * link to rules creation page * link to rules creation page * rename detections to alerts * fix unit tests * fix rules creation page * remove console * fix lint error * fix unit tests * fix unit tests * isolating rules and exceptions page * replace history push with navigateToApp * fix unit test * temporary fix for createCoreStartMock * update cypress * skip failing cypress * skip failing cypress Co-authored-by: semd <[email protected]> * Migrate "Investigate" tab group to new side navigation (#102705) * Migrate "Investigate" tab group to new side navigation It includes: * Timelines * Cases * Quick fix useFormatUrl and HeaderPage navigation * [Security Solutions] Management navigation (#102685) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * breadcrumbs changes and sidenav generation improvements * jest tests for breadcrumbs and navigation changes * retrocompatibility for sections that are not yet migrated to deepLinks * management deepLinks and plugin refactoring * home navigation changes * management navigation migrated to deeplinks * jest tests fixed * header page back link improved and tests fixed * type errors fixes * improve home navigation encapsulation Co-authored-by: Kibana Machine <[email protected]> * Fix type checking * export header page * fix padding * add redirect routes * unskip detection cypress * fix i18n * fix create your own rules btn * fix cancel button on rules creation page * test fixes * fix breadcrumbs for rules pages * unit test fixes * additional fixes * [Security Solutions] Navigation usage tracker and general changes (#103271) * [Security Solutions] use of currentAppId$ migrated. and some small fixes * unused constants removed * remove unused constant * test fix and types * fix cypress * fix cypress tests * Fix case navTab permission and tests * Revert 'timeline.isOpen' breadcrumb code that was deleted during merge * Fix useInsertTimeline test by removing '/' * change global navigation visible deeplinks * fix /admininstration top level redirect to * fix global search icon, nav order and overview hosts link * update start a new case link * fix rules link in exception list table * unskip cypress tests * update rules link * fix full screen timeline * fixing broken links and administration telemetry split * remove unused comments * remove timeline z-index and cleanup global header component * some minor fixes * add unit tests for detections breadcrumbs * remove case to global/search nav when cases is none * rename test scenario * fix side_panel flyout * fix cases use cases between search/gobal nav * timeline snapshot regenerated and cypres test fixed * rollback management tracking split as it causes unexpected errors on the telemetry component Co-authored-by: Pablo Machado <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Michael Olorunnisola <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]> Co-authored-by: Pablo Machado <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Michael Olorunnisola <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate management administration navigation migrated.
deepLinksinstead of registering each one.// TODO: [1101]commentsHave in mind this is a PR that will merge to the navigation Feature Branch, the integration with all other sections will be done later.
Checklist
Delete any items that are not applicable to this PR.
(https://github.com/elastic/kibana/blob/c29adfef29e921cc447d2a5ed06ac2047ceab552/src/dev/build/tasks/os_packages/docker_generator/resources/bin/kibana-docker)
For maintainers