Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Remove omitEsFieldValue and update parseEnvironmentUrlParam #101876

Merged
merged 8 commits into from
Jun 17, 2021
Merged

[APM] Remove omitEsFieldValue and update parseEnvironmentUrlParam #101876

merged 8 commits into from
Jun 17, 2021

Conversation

sorenlouv
Copy link
Member

Related to: #95903 (comment)

@sorenlouv sorenlouv requested a review from a team as a code owner June 10, 2021 11:07
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 10, 2021
@sorenlouv
Copy link
Member Author

jenkins run the e2e

@sorenlouv sorenlouv force-pushed the minor-refactor-esFieldValue-helper branch from 9fc8364 to 722558d Compare June 14, 2021 13:35
@sorenlouv sorenlouv requested a review from dgieselaar June 14, 2021 13:37
@sorenlouv sorenlouv added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 15, 2021
@sorenlouv sorenlouv force-pushed the minor-refactor-esFieldValue-helper branch from 27f7e4a to 36a758b Compare June 16, 2021 07:00
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.2MB 4.2MB -4.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 33.0KB 37.6KB +4.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit ca52347 into elastic:master Jun 17, 2021
@sorenlouv sorenlouv deleted the minor-refactor-esFieldValue-helper branch June 17, 2021 13:54
@kibanamachine kibanamachine mentioned this pull request Jun 17, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 17, 2021
@sorenlouv @kibanamachine
[APM] Remove omitEsFieldValue and update parseEnvironmentUrlParam (…
17f1f04 
…elastic#101876)
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 17, 2021
@kibanamachine @sorenlouv
[APM] Remove omitEsFieldValue and update parseEnvironmentUrlParam (…
bb924b1 
…#101876) (#102508)

Co-authored-by: Søren Louv-Jansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sorenlouv @elasticmachine @kibanamachine @dgieselaar