Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses minor comments from a PR that was auto-merged #101764

Conversation

stacey-gammon
Copy link
Contributor

I set #101661 up to auto-merge on LGTM, which meant I missed some minor feedback. Addressing in this separate PR.

@stacey-gammon stacey-gammon requested a review from azasypkin June 9, 2021 14:10
@stacey-gammon stacey-gammon added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 labels Jun 9, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these adjustments!

@stacey-gammon stacey-gammon marked this pull request as ready for review June 10, 2021 12:36
@stacey-gammon stacey-gammon requested a review from a team as a code owner June 10, 2021 12:36
@stacey-gammon stacey-gammon merged commit 65d3f49 into elastic:master Jun 10, 2021
@stacey-gammon stacey-gammon added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 10, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 10, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants