Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Lens] New summary row feature for datatable (#101075) #101740

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

* ✨ New summary row feature for datatable

* ✨ Allow empty strings behind flag + tests

* 🐛 Address the transition problem + refactor

* ✅ Add some unit tests

* ✅ Add first functional tests

* 👌 first feedback addressed

* ✨ Make it handle numeric array values

* 📝 Improved message

* ✅ Fix functional test

* 🔥 Remove warning message for last value

* 🚨 Remove unused import

* 🐛 Fix a bug with last value

* 👌 Integrated feedback

* 💄 Migrated to combobox

* ✅ Fix unit tests + restore right data-test-id

* 🏷️ Fix type issue

* 👌 Address all issues reported

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 670 672 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +6.7KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dej611

@kibanamachine kibanamachine merged commit efbad21 into elastic:7.x Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants