-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Fleet: Introduce API for uploading source maps for RUM #101623
[APM] Fleet: Introduce API for uploading source maps for RUM #101623
Conversation
Pinging @elastic/fleet (Team:Fleet) |
Pinging @elastic/apm-ui (Team:apm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fleet changes 🚀 (just a small unit test to change)
@elasticmachine merge upstream |
I think this update should be part of the |
@elasticmachine merge upstream |
Config is correctly rendered for APM server 👌 |
jenkins, test this (restarting due to jenkins upgrade) |
x-pack/plugins/apm/server/lib/fleet/register_fleet_policy_callbacks.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments. Great work!
…a into apm-flee-source-maps
💚 Build SucceededMetrics [docs]Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
…#101623) * creating fleet source maps apis * fixing ts issues * fixing test * fixing ts issue * nests `rum` under `config.apm-server.value` within the package policy input * refactoring and adding test * removing unit test * removing unused imports * addressing PR comments * addressing PR comments * addressing PR comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Oliver Gupte <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
#102897) * creating fleet source maps apis * fixing ts issues * fixing test * fixing ts issue * nests `rum` under `config.apm-server.value` within the package policy input * refactoring and adding test * removing unit test * removing unused imports * addressing PR comments * addressing PR comments * addressing PR comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Oliver Gupte <[email protected]> Co-authored-by: Cauê Marcondes <[email protected]> Co-authored-by: Oliver Gupte <[email protected]>
closes #95393
APIs:
GET /api/apm/sourcemaps
DELETE /api/apm/sourcemaps/{id}
POST /api/apm/sourcemaps/{serviceName}/{serviceVersion}
The body expects a JSON like:
When an source map is uploaded it changes the apm fleet package policies configuration located at
apm_server.value.rum.source_mapping.metadata
.Example: