Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Fix the LogStream story to work with KIPs #100862

Merged
merged 3 commits into from
Jun 4, 2021
Merged

[Logs UI] Fix the LogStream story to work with KIPs #100862

merged 3 commits into from
Jun 4, 2021

Conversation

weltenwort
Copy link
Member

Summary

This fixes the storybook story demoing the <LogStream /> component such that the index pattern service is correctly mocked.

@weltenwort weltenwort added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 28, 2021
@weltenwort weltenwort added this to the Logs UI 7.14 milestone May 28, 2021
@weltenwort weltenwort self-assigned this May 28, 2021
@weltenwort weltenwort marked this pull request as ready for review May 28, 2021 13:07
@weltenwort weltenwort requested a review from a team as a code owner May 28, 2021 13:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort mentioned this pull request May 28, 2021
Merged
@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@Kerry350 Kerry350 self-requested a review June 3, 2021 16:00
@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

Kerry350
Kerry350 approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@weltenwort weltenwort merged commit 081cf98 into elastic:master Jun 4, 2021
@weltenwort weltenwort deleted the logs-ui-fix-log-stream-story branch June 4, 2021 17:13
@kibanamachine kibanamachine mentioned this pull request Jun 4, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 4, 2021
@weltenwort @kibanamachine
[Logs UI] Fix the LogStream story to work with KIPs (elastic#100862)
e24b278 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 4, 2021
@kibanamachine @weltenwort
[Logs UI] Fix the LogStream story to work with KIPs (#100862) (#101415)
8cc984d 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Felix Stürmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees

@weltenwort weltenwort

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.14.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.14
Development

Successfully merging this pull request may close these issues.
4 participants
@weltenwort @elasticmachine @kibanamachine @Kerry350