Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test/functional/context] include missing await #100422

Merged
merged 2 commits into from
May 25, 2021
Merged

[test/functional/context] include missing await #100422

merged 2 commits into from
May 25, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 20, 2021

There's a missing await in a test which is causing the pageObject to keep talking to Chrome even after it is shutdown, causing sporadic failures like https://kibana-ci.elastic.co/job/elastic+kibana+master/14200/execution/node/512/log/

@spalger spalger added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.13.0 labels May 20, 2021
@spalger spalger requested a review from kertal May 20, 2021 20:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@spalger
Copy link
Contributor Author

spalger commented May 24, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal
kertal approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for fixing this!

@spalger spalger merged commit 7bd46ec into elastic:master May 25, 2021
@spalger spalger deleted the fix/missing-await branch May 25, 2021 07:01
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label May 25, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 25, 2021
@spalger @kibanamachine
[test/functional/context] include missing await (elastic#100422)
493af70 
Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request May 25, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 25, 2021
@spalger @kibanamachine
[test/functional/context] include missing await (elastic#100422)
a0e0b5c 
Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request May 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 25, 2021
@kibanamachine @spalger
[test/functional/context] include missing await (#100422) (#100529)
b25c577 
Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Spencer <[email protected]>
Co-authored-by: spalger <[email protected]>
kibanamachine added a commit that referenced this pull request May 25, 2021
@kibanamachine @spalger
[test/functional/context] include missing await (#100422) (#100528)
3cd6732 
Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Spencer <[email protected]>
Co-authored-by: spalger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @elasticmachine @kibanamachine @kertal