Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedDataTable] Add document/field diffing #93567

Closed
kertal opened this issue Mar 4, 2021 · 1 comment · Fixed by #166577
Closed

[UnifiedDataTable] Add document/field diffing #93567

kertal opened this issue Mar 4, 2021 · 1 comment · Fixed by #166577
Assignees
@davismcphee
Labels
enhancement New value added to drive a business result epic Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Mar 4, 2021 •
edited
Loading

When EuiDataGrid in Discover allows users to select and compare documents/fields (#93453) it will be useful. So let's make it awesome. For certain tasks it would be very useful do introduce diffing. For example you could to diff a SIP message of a certain ID sent from several components with several documents in Elasticsearch. Would be useful for debugging. Here's a mockup how it could look like.
image

Diffing could be done by EUI's text diff functionality (https://elastic.github.io/eui/#/utilities/text-diff)
@kertal kertal added Feature:Discover Discover Application enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal mentioned this issue Mar 4, 2021
Closed
41 tasks
@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@kertal kertal mentioned this issue Dec 6, 2022
Closed
2 tasks
@lukasolson lukasolson added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Dec 13, 2022
@kertal kertal added loe:x-large Extra Large Level of Effort and removed loe:medium Medium Level of Effort labels Jan 18, 2023
@davismcphee davismcphee added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Sep 8, 2023
@davismcphee davismcphee mentioned this issue Sep 25, 2023
Merged
9 tasks
@davismcphee davismcphee mentioned this issue Sep 28, 2023
Closed
@kertal kertal changed the title [Discover][EuiDataGrid] Add document/field diffing [UnifiedDataTable] Add document/field diffing Oct 2, 2023
@kertal kertal added loe:large Large Level of Effort and removed loe:x-large Extra Large Level of Effort labels Oct 4, 2023
@kertal kertal added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Nov 29, 2023
davismcphee added a commit that referenced this issue Apr 10, 2024
@davismcphee @kibanamachine
[Discover] [Unified Data Table] Add document comparison mode (#166577)
339379e 
## Summary

This PR adds a new document comparison mode to Discover and Unified Data
Table:

![diff](https://github.com/elastic/kibana/assets/25592674/40edf401-9514-4388-87a2-c528dbdd6f90)

Flaky test runner x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5590.

Resolves #93567.

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davismcphee davismcphee

Labels
enhancement New value added to drive a business result epic Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] [Unified Data Table] Add document comparison mode davismcphee/kibana
6 participants
@kertal @timroes @lukasolson @timductive @elasticmachine @davismcphee