Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use index pattern service to load index patterns #91715

Closed
16 of 18 tasks
mattkime opened this issue Feb 17, 2021 · 2 comments
Closed
16 of 18 tasks

Use index pattern service to load index patterns #91715

mattkime opened this issue Feb 17, 2021 · 2 comments
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Meta Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@mattkime
Copy link
Contributor

mattkime commented Feb 17, 2021

There are a number of places where kibana index patterns are loaded directly from the Saved Object API instead of the index patterns service on the data plugin. This essentially treats the index pattern saved objects as an api in itself and makes changing the index patterns api more difficult. In particular, we'd like to be able to separate out the index pattern string from the displayed title of the index pattern. This issue tracks the changes needed to remove working directly with saved objects.

@rudolf
Copy link
Contributor

rudolf commented Mar 5, 2021

Once we've migrated all plugins over to the index patterns service we should consider setting hidden: true for the index-pattern saved object to block any plugins from reading these directly again in the future. This would require adding an index pattern HTTP API (if we don't already have one) and we would have to document it so that external users who might be relying on the saved objects API can switch to this dedicated API instead.

This is a pattern we want all saved objects to adopt in the long term #72028

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Oct 6, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Dec 21, 2021
@kertal
Copy link
Member

kertal commented Sep 2, 2024

Closing this, because it's > 3 years old, and except #153368 all seems to be resolved, or the linked code is no longer valid

@kertal kertal closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Meta Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

6 participants