Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the data plugin's index-pattern APIs for the "Should show the interstitial page" validation #108711

Closed
afharo opened this issue Aug 16, 2021 · 3 comments · Fixed by #109650
Closed

Use the data plugin's index-pattern APIs for the "Should show the interstitial page" validation #108711

afharo opened this issue Aug 16, 2021 · 3 comments · Fixed by #109650
Assignees
@afharo
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Aug 16, 2021

There are plans to block plugins from accessing the index-patterns SOs (#91715).

We use it in the Home plugin to validate whether we should show the interstitial page or not: src/plugins/home/public/application/components/home.js:78

Let's use the data plugin's APIs to run those validations.
@afharo afharo added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Aug 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo mentioned this issue Aug 16, 2021
Closed
18 tasks
@afharo
Copy link
Member Author

afharo commented Aug 16, 2021

cc @joshdover since he recently revisited that piece of logic in #108193

@Dosant Dosant mentioned this issue Aug 18, 2021
Merged
@afharo afharo self-assigned this Aug 19, 2021
@afharo
Copy link
Member Author

afharo commented Aug 20, 2021

Waiting for #108887 to be merged so we can replace our entire logic with a simple call to the new API hasUserIndexPattern.

@afharo afharo mentioned this issue Aug 23, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afharo afharo

Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Home] Use unified API to show/hide the Welcome interstitial afharo/kibana
2 participants
@afharo @elasticmachine