Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Firefox UI Functional Tests.test/functional/apps/dashboard/dashboard_save·ts - dashboard app using legacy data dashboard save warns on duplicate name for new dashboard #89476

Closed
kibanamachine opened this issue Jan 27, 2021 · 4 comments · Fixed by #98830
Closed

Failing test: Firefox UI Functional Tests.test/functional/apps/dashboard/dashboard_save·ts - dashboard app using legacy data dashboard save warns on duplicate name for new dashboard #89476

kibanamachine opened this issue Jan 27, 2021 · 4 comments · Fixed by #98830
Assignees
@cqliu1
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.12.0

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

Error: retry.try timeout: Error: expected testSubject(saveDashboardSuccess) to exist
    at TestSubjects.existOrFail (test/functional/services/common/test_subjects.ts:51:15)
    at /dev/shm/workspace/parallel/19/kibana/test/functional/page_objects/dashboard_page.ts:314:9
    at runAttempt (test/common/services/retry/retry_for_success.ts:27:15)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:66:21)
    at Retry.try (test/common/services/retry/retry.ts:32:14)
    at DashboardPage.saveDashboard (test/functional/page_objects/dashboard_page.ts:305:7)
    at Context.<anonymous> (test/functional/apps/dashboard/dashboard_save.ts:26:7)
    at Object.apply (packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
    at onFailure (test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:57:13)
    at Retry.try (test/common/services/retry/retry.ts:32:14)
    at DashboardPage.saveDashboard (test/functional/page_objects/dashboard_page.ts:305:7)
    at Context.<anonymous> (test/functional/apps/dashboard/dashboard_save.ts:26:7)
    at Object.apply (packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 27, 2021
spalger added a commit that referenced this issue Jan 27, 2021
@spalger
skip flaky suite (#89476)
44b8333
spalger added a commit that referenced this issue Jan 27, 2021
@spalger
skip flaky suite (#89476)
737f2a4 
(cherry picked from commit 44b8333)
@spalger spalger mentioned this issue Jan 27, 2021
Closed
@spalger
Copy link
Contributor

spalger commented Jan 27, 2021

First failure on master, but 4 PR failures in the last 48 hours

image

Skipped

master: 44b8333
7.x/7.12: 737f2a4

@spalger spalger added blocker skipped-test Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 labels Jan 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

jloleysens added a commit to jloleysens/kibana that referenced this issue Jan 28, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/basic-a11…
e814056 
…y-tests

* 'master' of github.com:elastic/kibana: (31 commits)
  [Discover] Add grid flyout jest test (elastic#89088)
  [Search Sessions] Improve session restoration back button (elastic#87635)
  [TSVB] Remove vis_type_timeseries_enhanced plugin (elastic#89274)
  [Security Solution] Init Osquery plugin (elastic#87109)
  [Fleet] Do not defined aliases inside datastream template (elastic#89512)
  skip flaky suite (elastic#86950)
  chore(NA): bazel machinery installation on kbn bootstrap (elastic#89469)
  [build/docker] Add support for centos ARM builds (elastic#84831)
  Convert default_watch.json to a JS object in order to avoid TS complaints (elastic#89488)
  [CI] Decrease number of Jest workers (elastic#89504)
  [Maps] remove maps_oss TS project (elastic#89502)
  Adds migration settings to Docker (elastic#89501)
  [Lens] Fix crash in transition from unique count to last value (elastic#88916)
  [kbn-es] Always use bundled JDK when starting Elasticsearch (elastic#89437)
  unskip getting_started/shakespeare test elasticsearch 64016 (elastic#89346)
  [Maps] migrate maps, maps_file_upload, and maps_legacy_licensing to TS projects (elastic#89439)
  skip flaky suite (elastic#89478)
  skip flaky suite (elastic#89476)
  skip flaky suite (elastic#89477)
  skip flaky suite (elastic#89475)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx
jloleysens added a commit to jloleysens/kibana that referenced this issue Jan 28, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/rollover-…
494a041 
…updates-and-timeline-cleanup

* 'master' of github.com:elastic/kibana: (44 commits)
  [Discover] Add grid flyout jest test (elastic#89088)
  [Search Sessions] Improve session restoration back button (elastic#87635)
  [TSVB] Remove vis_type_timeseries_enhanced plugin (elastic#89274)
  [Security Solution] Init Osquery plugin (elastic#87109)
  [Fleet] Do not defined aliases inside datastream template (elastic#89512)
  skip flaky suite (elastic#86950)
  chore(NA): bazel machinery installation on kbn bootstrap (elastic#89469)
  [build/docker] Add support for centos ARM builds (elastic#84831)
  Convert default_watch.json to a JS object in order to avoid TS complaints (elastic#89488)
  [CI] Decrease number of Jest workers (elastic#89504)
  [Maps] remove maps_oss TS project (elastic#89502)
  Adds migration settings to Docker (elastic#89501)
  [Lens] Fix crash in transition from unique count to last value (elastic#88916)
  [kbn-es] Always use bundled JDK when starting Elasticsearch (elastic#89437)
  unskip getting_started/shakespeare test elasticsearch 64016 (elastic#89346)
  [Maps] migrate maps, maps_file_upload, and maps_legacy_licensing to TS projects (elastic#89439)
  skip flaky suite (elastic#89478)
  skip flaky suite (elastic#89476)
  skip flaky suite (elastic#89477)
  skip flaky suite (elastic#89475)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.ts
@rashmivkulkarni
Copy link
Contributor

stack trace from 7.12.0

[00:19:10]                 └- ✖ fail: dashboard app using legacy data dashboard save Does not show dashboard save modal when on quick save
[00:19:10]                 │      Error: expected testSubject(saveDashboardSuccess) to exist
[00:19:10]                 │       at TestSubjects.existOrFail (test/functional/services/common/test_subjects.ts:51:15)
[00:19:10]                 │       at Context.<anonymous> (test/functional/apps/dashboard/dashboard_save.ts:132:7)
[00:19:10]                 │       at Object.apply (node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

part of #95349
Screen Shot 2021-04-01 at 2 31 12 PM

@elastic/kibana-presentation (Team:Presentation) cc @LeeDr

@cqliu1 cqliu1 self-assigned this Apr 29, 2021
@cqliu1 cqliu1 mentioned this issue Apr 29, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqliu1 cqliu1

Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard] Fixes dashboard_save functional test cqliu1/kibana
6 participants
@spalger @cqliu1 @rashmivkulkarni @elasticmachine @stratoula @kibanamachine