Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add experimental support for data streams #87501

Closed
jalvz opened this issue Jan 6, 2021 · 10 comments · Fixed by #89650
Closed

[APM] Add experimental support for data streams #87501

jalvz opened this issue Jan 6, 2021 · 10 comments · Fixed by #89650
Assignees
Labels
Team:APM All issues that need APM UI Team support v7.12.0

Comments

@jalvz
Copy link
Contributor

jalvz commented Jan 6, 2021

Right now APM pulls data from apm-* indices.

For the data streams feature coming with Fleet integration, we need a new set of additional defaults:

logs-apm*
metrics-apm*
traces-apm*

Notice there is no dash in the suffix (*, no -*)

We won't manage onboarding nor sourcemap indices (See #86462 and elastic/apm-server#3606 for details on those)

Let me know if something is unclear.

@jalvz jalvz added the Team:APM All issues that need APM UI Team support label Jan 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

Sounds like this is just a matter of updating the defaults in:

transactionIndices: schema.string({ defaultValue: 'apm-*' }),
spanIndices: schema.string({ defaultValue: 'apm-*' }),
errorIndices: schema.string({ defaultValue: 'apm-*' }),
metricsIndices: schema.string({ defaultValue: 'apm-*' }),
sourcemapIndices: schema.string({ defaultValue: 'apm-*' }),
onboardingIndices: schema.string({ defaultValue: 'apm-*' }),
indexPattern: schema.string({ defaultValue: 'apm-*' }),

@jalvz When is this needed for?

@jalvz
Copy link
Contributor Author

jalvz commented Jan 7, 2021

7.12!

@simitt
Copy link
Contributor

simitt commented Jan 12, 2021

Just in case this isn't clear to everyone, the new indexing strategy will ingest like this:

errors -> logs-apm*
transactions -> traces-apm*
spans -> traces-apm*
metrics -> metrics-apm*

The new defaults for the events should therefore look like this:

transactionIndices: schema.string({ defaultValue: 'apm-*,traces-apm*' }), 
spanIndices: schema.string({ defaultValue: 'apm-*,traces-apm*' }), 
errorIndices: schema.string({ defaultValue: 'apm-*,logs-apm*' }), 
metricsIndices: schema.string({ defaultValue: 'apm-*,metrics-apm*' })

Not quite sure if/what we need to change for the index-pattern.

@sorenlouv
Copy link
Member

sorenlouv commented Jan 12, 2021

Thanks for clarifying @simitt

Not quite sure if/what we need to change for the index-pattern.

Good question. We probably should change that to *apm* to capture everything

@dgieselaar
Copy link
Member

The permissions of the kibana_system role need to be updated as well (in ES, and possibly cloud, depending on how far they are with migrating to using the kibana_system role). We also need to think about users that have specified custom indices.

@sorenlouv
Copy link
Member

The permissions of the kibana_system role need to be updated as well

This, right?

We also need to think about users that have specified custom indices

True. Users who already specified custom indices and then moves to fleet won't see the updated default values presented here.
Perhaps we shouldn't solve this problem by updating the defaults. Perhaps we should hardcode these values so we are sure they will apply to everyone (they also shouldn't be configurable in the future anyway).

@simitt
Copy link
Contributor

simitt commented Jan 12, 2021

Perhaps we should hardcode these values so we are sure they will apply to everyone (they also shouldn't be configurable in the future anyway).

That would mean hardcode the new values + combine them with either the current default values or the user provided values? Sounds good to me. If they are not using the new indexing strategy, nothing changes; in case they do, they would still see old and new data, which sounds great.

@sorenlouv
Copy link
Member

sorenlouv commented Jan 12, 2021

That would mean hardcode the new values + combine them with either the current default values or the user provided values?

Yes, that's what I mean. Sounds like we have a plan 👍

@sorenlouv
Copy link
Member

fyi: created an issue to track the deprecation of UI indices in 8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v7.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants