Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service overview tab and route #81718

Closed
smith opened this issue Oct 27, 2020 · 1 comment · Fixed by #81972
Closed

[APM] Service overview tab and route #81718

smith opened this issue Oct 27, 2020 · 1 comment · Fixed by #81972
Assignees
@smith
Labels
apm:service-overview Team:APM All issues that need APM UI Team support v7.11.0

Comments

@smith
Copy link
Contributor

smith commented Oct 27, 2020 •
edited
Loading

(Part of the new APM service overview. See #81135 for more.)

#81154 adds a tab and experimental setting where the tab is present but you can't click through to it.

  • /services/:serviceName/overview loads the new page in a new "Overview" tab (it doesn't need contents at the moment; see the other issues.)

The new page is called the service overview and the tab is labeled "Overview", however, the existing landing page with the list of all services is also called ServiceOverview so should be renamed to something that indicates its a place that lists all services, while "service overview" is reserved for this new landing page for a single service.
@smith smith added Team:APM All issues that need APM UI Team support apm:service-overview labels Oct 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith mentioned this issue Oct 27, 2020
Merged
@smith smith self-assigned this Oct 28, 2020
smith added a commit to smith/kibana that referenced this issue Oct 28, 2020
@smith
Rename "service overview" to "service inventory"
0c832f4 
To remove confusion when implementing elastic#81718, rename the existing "service overview" to "service inventory."

* Rename `ServiceOverviewLink` to `ServiceInventoryLink`
* Remove service inventory test snapshots
* Rename `ServiceOverview` to `ServiceInventory`
* Add `service_inventory` to pageview tracking
* Rename i18n keys for service inventory
* Change "return to overview" link to "return to inventory" on settings page
* Rename `fetchOverviewPageData` to `fetchObservabilityOverviewPageData`
@smith smith mentioned this issue Oct 28, 2020
Merged
@smith smith added the v7.11.0 label Oct 28, 2020
smith added a commit to smith/kibana that referenced this issue Oct 29, 2020
@smith
Service overview tab and route
bb000d3 
Placeholder tab and route for service overview page.

Fixes elastic#81718.
@smith smith mentioned this issue Oct 29, 2020
Merged
smith added a commit that referenced this issue Oct 29, 2020
@smith
Service overview tab and route (#81972)
4ca013e 
Placeholder tab and route for service overview page.

Fixes #81718.
smith added a commit to smith/kibana that referenced this issue Oct 29, 2020
@smith
Service overview tab and route (elastic#81972)
9e70c1c 
Placeholder tab and route for service overview page.

Fixes elastic#81718.
smith added a commit that referenced this issue Oct 30, 2020
@smith
Service overview tab and route (#81972) (#82046)
bafc89e 
Placeholder tab and route for service overview page.

Fixes #81718.
smith added a commit that referenced this issue Oct 30, 2020
@smith
Rename "service overview" to "service inventory" (#81933)
877ad5a 
To remove confusion when implementing #81718, rename the existing "service overview" to "service inventory."

* Rename `ServiceOverviewLink` to `ServiceInventoryLink`
* Remove service inventory test snapshots
* Rename `ServiceOverview` to `ServiceInventory`
* Add `service_inventory` to pageview tracking
* Rename i18n keys for service inventory
* Change "return to overview" link to "return to inventory" on settings page
* Rename `fetchOverviewPageData` to `fetchObservabilityOverviewPageData`
smith added a commit to smith/kibana that referenced this issue Oct 30, 2020
@smith
Rename "service overview" to "service inventory" (elastic#81933)
6406909 
To remove confusion when implementing elastic#81718, rename the existing "service overview" to "service inventory."

* Rename `ServiceOverviewLink` to `ServiceInventoryLink`
* Remove service inventory test snapshots
* Rename `ServiceOverview` to `ServiceInventory`
* Add `service_inventory` to pageview tracking
* Rename i18n keys for service inventory
* Change "return to overview" link to "return to inventory" on settings page
* Rename `fetchOverviewPageData` to `fetchObservabilityOverviewPageData`
smith added a commit that referenced this issue Oct 30, 2020
@smith
Rename "service overview" to "service inventory" (#81933) (#82181)
3d83315 
To remove confusion when implementing #81718, rename the existing "service overview" to "service inventory."

* Rename `ServiceOverviewLink` to `ServiceInventoryLink`
* Remove service inventory test snapshots
* Rename `ServiceOverview` to `ServiceInventory`
* Add `service_inventory` to pageview tracking
* Rename i18n keys for service inventory
* Change "return to overview" link to "return to inventory" on settings page
* Rename `fetchOverviewPageData` to `fetchObservabilityOverviewPageData`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
apm:service-overview Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Service overview tab and route smith/kibana
3 participants
@smith @sorenlouv @elasticmachine