-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution]UI [drop down icon and text] is broken when "severity override" is checked under the create a new rule tab. #81284
Comments
…"Create new rule" -> "About rule" (#82271) We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the #81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
Thanks for the fix @banderror!! When a bug is fixed we label it with the @spong @peluja1012 as this is already fixed what to do you think about targeting 7.10.1 as well? |
…"Create new rule" -> "About rule" (elastic#82271) We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the elastic#81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
Sorry @MadameSheema I went through the merge process with @banderror and it seems to have closed the ticket automatically on merge because it was linked in the PR. Wonder if there's a setting to prevent automatic closure of tickets on merge. |
@MadameSheema It's a low-risk fix so I'm not opposed to targeting 7.10.1 as well since this is a nice usability enhancement. |
…"Create new rule" -> "About rule" (#82271) (#82427) We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the #81284 you can see the placeholders' text being split into multiple lines that gives this messy effect. Co-authored-by: Kibana Machine <[email protected]>
…"Create new rule" -> "About rule" (elastic#82271) We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the elastic#81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
…"Create new rule" -> "About rule" (#82271) (#83272) We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the #81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
We have validated this issue on "7.10.1-SNAPSHOT" and found that issue is Fixed. Severity Override section drop-down icon and text displayed properly on UI. Moreover we have Updated 01 Existing Test-case for this issue. Build details:
Artifact Page : https://artifacts-api.elastic.co/v1/search/7.10.1-SNAPSHOT Snap-Shoot: Test-Case Updated:
Test-Case Execution :
Please let us known if we are missing something. we will close this issue once BC build for 7.10.1 will be available. thanks !! |
Originally reported by: @deepikakeshav-qasource
Describe the bug
UI [drop down icon and text] is broken when "severity override" is checked under the create a new rule tab.
Build Details:
Browser Details
All
Preconditions
Steps to Reproduce
Impacted Test case(s)
N/A
Actual Result
UI [drop down icon and text] is broken when "severity override" is checked under the create a new rule tab.
Expected Result
Text and drop-down icon should not be broken when "severity override" is checked under the create a new rule tab.
What's Working
N/A
What's Not Working
This issue is also occurring on MacOS safari
Screenshot:
The text was updated successfully, but these errors were encountered: