Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]UI [drop down icon and text] is broken when "severity override" is checked under the create a new rule tab. #81284

Closed
MadameSheema opened this issue Oct 21, 2020 · 5 comments · Fixed by #82271
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.10.1 v7.11.0

Comments

@MadameSheema
Copy link
Member

Originally reported by: @deepikakeshav-qasource

Describe the bug
UI [drop down icon and text] is broken when "severity override" is checked under the create a new rule tab.

Build Details:

Elastic-Stack: 7.10.0

Browser Details
All

Preconditions

  1. Kibana and elastic search should be up and running
  2. Audit beat Data Shipper should be installed and running.

Steps to Reproduce

  1. Navigate to the Detections tab
  2. Click on Create new rule.
  3. Fill Custom query with: host.name: * and click on the Continue button
  4. In the About rule section select the "severity override" checkbox.
  5. Observe that text and drop-down icon UI is broken.

Impacted Test case(s)
N/A

Actual Result
UI [drop down icon and text] is broken when "severity override" is checked under the create a new rule tab.

Expected Result
Text and drop-down icon should not be broken when "severity override" is checked under the create a new rule tab.

What's Working
N/A

What's Not Working
This issue is also occurring on MacOS safari

Screenshot:
Severity_create_rule

@MadameSheema MadameSheema added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v7.11.0 Team:Detections and Resp Security Detection Response Team labels Oct 21, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
banderror added a commit that referenced this issue Nov 3, 2020
…"Create new rule" -> "About rule" (#82271)

We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the #81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
@MadameSheema
Copy link
Member Author

Thanks for the fix @banderror!!

When a bug is fixed we label it with the fixed label and we keep it open until we can validate it on the next release process ;)

@spong @peluja1012 as this is already fixed what to do you think about targeting 7.10.1 as well?

@MadameSheema MadameSheema reopened this Nov 3, 2020
banderror added a commit to banderror/kibana that referenced this issue Nov 3, 2020
…"Create new rule" -> "About rule" (elastic#82271)

We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the elastic#81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
@yctercero
Copy link
Contributor

Sorry @MadameSheema I went through the merge process with @banderror and it seems to have closed the ticket automatically on merge because it was linked in the PR. Wonder if there's a setting to prevent automatic closure of tickets on merge.

@spong
Copy link
Member

spong commented Nov 4, 2020

@MadameSheema It's a low-risk fix so I'm not opposed to targeting 7.10.1 as well since this is a nice usability enhancement.

banderror added a commit that referenced this issue Nov 4, 2020
…"Create new rule" -> "About rule" (#82271) (#82427)

We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the #81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.

Co-authored-by: Kibana Machine <[email protected]>
banderror added a commit to banderror/kibana that referenced this issue Nov 12, 2020
…"Create new rule" -> "About rule" (elastic#82271)

We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the elastic#81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
banderror added a commit that referenced this issue Nov 12, 2020
…"Create new rule" -> "About rule" (#82271) (#83272)

We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the #81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
@banderror banderror added the Feature:Detection Rules Security Solution rules and Detection Engine label Nov 17, 2020
@ghost
Copy link

ghost commented Nov 26, 2020

Hi @MadameSheema

We have validated this issue on "7.10.1-SNAPSHOT" and found that issue is Fixed. Severity Override section drop-down icon and text displayed properly on UI.

Moreover we have Updated 01 Existing Test-case for this issue.

Build details:

Platform : Staging
Version : 7.10.1
Commit:8429d582611223b275fe05c987b06583744c52c2
Build number : 36023
Firefox: 83.0

Artifact Page : https://artifacts-api.elastic.co/v1/search/7.10.1-SNAPSHOT

Snap-Shoot:

image


Test-Case Updated:

  • Updated 01 Test-Cases
Test-Case Link Title Remark
C18045 Validate that Severity override apply correctly on Alert Added UI Validation Checkpoint

Test-Case Execution :

Test-Case Link Title Remark
C18045 Validate that Severity override apply correctly on Alert Pass

Please let us known if we are missing something. we will close this issue once BC build for 7.10.1 will be available.

thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.10.1 v7.11.0
Projects
None yet
5 participants