Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizations] Remove the setters/getters from the plugin #80951

Closed
stratoula opened this issue Oct 19, 2020 · 2 comments
Closed

[Visualizations] Remove the setters/getters from the plugin #80951

stratoula opened this issue Oct 19, 2020 · 2 comments
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Oct 19, 2020

Describe the feature:
Right now on the Visualizations plugin https://github.com/elastic/kibana/blob/master/src/plugins/visualizations/public/plugin.ts#L32, we use setters to set the services that the plugin needs and getters to get the services and use them wherever we want.

We want to remove this logic as it makes the code more complex and may cause some bugs.

So, for example, many setters are used to the wizard modal. We could change it to something like:
createShowNewVisModal(deps) => showNewVisModal

and ideally, remove the services.ts file.

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula added technical debt Improvement of the software architecture and operational architecture and removed technical debt Improvement of the software architecture and operational architecture labels Oct 19, 2020
@stratoula
Copy link
Contributor Author

Duplicate of #63596

@stratoula stratoula marked this as a duplicate of #63596 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants