Shorten and Copy at same time #8061
Labels
Feature:SharingURLs
Short URLs and Share URL features
release_note:enhancement
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Comments
|
Sounds like a good idea to me |
timroes
added
Team:Visualizations
|
Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment. |
delanni
pushed a commit
that referenced
this issue
Oct 14, 2024
`v96.1.0`⏩`v97.0.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.0.0`](https://github.com/elastic/eui/releases/v97.0.0) **Breaking changes** - EuiDataGrid's custom grid body (rendered via `renderCustomGridBody`) no longer automatically renders the column header row or footer rows. It instead now passes the `headerRow` and `footerRow` React elements, which require manual rendering. ([#8028](elastic/eui#8028)) - This change was made to allow consumers to sync header/footer rows with their own custom virtualization libraries. - To facilitate this, a `gridWidth` prop is now also passed to custom grid body renderers. **Bug fixes** - Fixed inputs not taking the whole width when passing `fullWidth` as `true` to EuiDatePickerRange component ([#8061](elastic/eui#8061)) **Accessibility** - Improved accessibility of `EuiExternalLinkIcon` by clarifying text for Screen Reader users. ([#8065](elastic/eui#8065)) --------- Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 14, 2024
`v96.1.0`⏩`v97.0.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.0.0`](https://github.com/elastic/eui/releases/v97.0.0) **Breaking changes** - EuiDataGrid's custom grid body (rendered via `renderCustomGridBody`) no longer automatically renders the column header row or footer rows. It instead now passes the `headerRow` and `footerRow` React elements, which require manual rendering. ([elastic#8028](elastic/eui#8028)) - This change was made to allow consumers to sync header/footer rows with their own custom virtualization libraries. - To facilitate this, a `gridWidth` prop is now also passed to custom grid body renderers. **Bug fixes** - Fixed inputs not taking the whole width when passing `fullWidth` as `true` to EuiDatePickerRange component ([elastic#8061](elastic/eui#8061)) **Accessibility** - Improved accessibility of `EuiExternalLinkIcon` by clarifying text for Screen Reader users. ([elastic#8065](elastic/eui#8065)) --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit cd60c66)
kibanamachine
added a commit
that referenced
this issue
Oct 14, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Upgrade EUI to v97.0.0 (#195525)](#195525) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T11:35:35Z","message":"Upgrade EUI to v97.0.0 (#195525)\n\n`v96.1.0`⏩`v97.0.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.0.0`](https://github.com/elastic/eui/releases/v97.0.0)\r\n\r\n**Breaking changes**\r\n\r\n- EuiDataGrid's custom grid body (rendered via `renderCustomGridBody`)\r\nno longer automatically renders the column header row or footer rows. It\r\ninstead now passes the `headerRow` and `footerRow` React elements, which\r\nrequire manual rendering.\r\n([#8028](https://github.com/elastic/eui/pull/8028))\r\n- This change was made to allow consumers to sync header/footer rows\r\nwith their own custom virtualization libraries.\r\n- To facilitate this, a `gridWidth` prop is now also passed to custom\r\ngrid body renderers.\r\n\r\n**Bug fixes**\r\n\r\n- Fixed inputs not taking the whole width when passing `fullWidth` as\r\n`true` to EuiDatePickerRange component\r\n([#8061](https://github.com/elastic/eui/pull/8061))\r\n\r\n**Accessibility**\r\n\r\n- Improved accessibility of `EuiExternalLinkIcon` by clarifying text for\r\nScreen Reader users. ([#8065](https://github.com/elastic/eui/pull/8065))\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"cd60c66d19ffdb4130a5c2d1b76e80cfaf8cde78","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","release_note:skip","EUI","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.16.0","backport:version"],"title":"Upgrade EUI to v97.0.0","number":195525,"url":"https://github.com/elastic/kibana/pull/195525","mergeCommit":{"message":"Upgrade EUI to v97.0.0 (#195525)\n\n`v96.1.0`⏩`v97.0.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.0.0`](https://github.com/elastic/eui/releases/v97.0.0)\r\n\r\n**Breaking changes**\r\n\r\n- EuiDataGrid's custom grid body (rendered via `renderCustomGridBody`)\r\nno longer automatically renders the column header row or footer rows. It\r\ninstead now passes the `headerRow` and `footerRow` React elements, which\r\nrequire manual rendering.\r\n([#8028](https://github.com/elastic/eui/pull/8028))\r\n- This change was made to allow consumers to sync header/footer rows\r\nwith their own custom virtualization libraries.\r\n- To facilitate this, a `gridWidth` prop is now also passed to custom\r\ngrid body renderers.\r\n\r\n**Bug fixes**\r\n\r\n- Fixed inputs not taking the whole width when passing `fullWidth` as\r\n`true` to EuiDatePickerRange component\r\n([#8061](https://github.com/elastic/eui/pull/8061))\r\n\r\n**Accessibility**\r\n\r\n- Improved accessibility of `EuiExternalLinkIcon` by clarifying text for\r\nScreen Reader users. ([#8065](https://github.com/elastic/eui/pull/8065))\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"cd60c66d19ffdb4130a5c2d1b76e80cfaf8cde78"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195525","number":195525,"mergeCommit":{"message":"Upgrade EUI to v97.0.0 (#195525)\n\n`v96.1.0`⏩`v97.0.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.0.0`](https://github.com/elastic/eui/releases/v97.0.0)\r\n\r\n**Breaking changes**\r\n\r\n- EuiDataGrid's custom grid body (rendered via `renderCustomGridBody`)\r\nno longer automatically renders the column header row or footer rows. It\r\ninstead now passes the `headerRow` and `footerRow` React elements, which\r\nrequire manual rendering.\r\n([#8028](https://github.com/elastic/eui/pull/8028))\r\n- This change was made to allow consumers to sync header/footer rows\r\nwith their own custom virtualization libraries.\r\n- To facilitate this, a `gridWidth` prop is now also passed to custom\r\ngrid body renderers.\r\n\r\n**Bug fixes**\r\n\r\n- Fixed inputs not taking the whole width when passing `fullWidth` as\r\n`true` to EuiDatePickerRange component\r\n([#8061](https://github.com/elastic/eui/pull/8061))\r\n\r\n**Accessibility**\r\n\r\n- Improved accessibility of `EuiExternalLinkIcon` by clarifying text for\r\nScreen Reader users. ([#8065](https://github.com/elastic/eui/pull/8065))\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"cd60c66d19ffdb4130a5c2d1b76e80cfaf8cde78"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cee Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Any reason we couldn't change the 'Shorten' share button to also copy to clipboard? Why would you want to shorten but not copy? I'll put up PR if maintainers think this is a good idea.
https://github.com/elastic/kibana/blob/6025200731803df67835246b4f7d7153cda2670d/src/ui/public/share/views/share_object_url.html
The text was updated successfully, but these errors were encountered: