Inactive karma tests #71002
Comments
joshdover
added
chore
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
This file was referenced in elastic#71002 but is not being used. Delete it.
This file was referenced in #71002 but is not being used. Delete it.
This file was referenced in elastic#71002 but is not being used. Delete it.
|
@jasonrhodes @thomasneirynck @lukeelmers Karma has been removed( #73126), please migrate the tests listed in this issue to Jest or remove them. |
|
@jinmu03 PR for migrating the remaining app arch tests is up here. |
|
This is the PR for the legacy maps code: #74668 |
|
Ping @chrisronline as well for the Stack Monitoring tests |
|
@joshdover What's the timeline for this? |
|
@joshdover the APM test was removed by Nathan in 67be99d. I'll update the description. |
|
@joshdover PR up for stack monitoring tests: #75301 |
It's handled by jest, so it's not a blocker. @shahzad31 could you confirm, please? Another file that still matches the pattern is |
|
@restrry you are right the test is handled by jest
|
|
@restrry the canvas file was mentioning enzyme, which isn't used in the browser tests best I know so I assumed it was used by jest tests somehow. I'm guessing that the file isn't used by anything so I submitted #76295 |
When plugins were migrated to the Kibana Platform, any existing tests that were run using Karma stopped being picked up by the Karma test bundling system. We are making progress on removing this system entirely, but want to inform teams that these tests are not currently being executed. These tests should either be removed or refactored to use the Jest test runner. This is not blocking any work on the Platform team at this time, but there is a risk that the reduction in test coverage may cause future problems.
Command used to find these files:
git ls-files - {src,x-pack}/plugins/*/public/{**,*,}/__tests__/** | grep -Ev ".*\.test\.(js|ts|tsx)(\.snap)?\$" | grep -E "\.(js|ts|tsx)\$"@elastic/kibana-app-arch
src/plugins/kibana_utils/public/storage/__tests__/storage.jssrc/plugins/visualizations/public/legacy/__tests__/vis_update_objs/gauge_objs.js@elastic/kibana-gis
src/plugins/maps_legacy/public/__tests__/map/kibana_map.jssrc/plugins/maps_legacy/public/__tests__/map/service_settings.js(migrated Migrate service settings test to jest #70992)src/plugins/region_map/public/__tests__/region_map_visualization.jssrc/plugins/tile_map/public/__tests__/coordinate_maps_visualization.jssrc/plugins/tile_map/public/__tests__/geohash_layer.jsx-pack/plugins/maps/public/classes/layers/__tests__/mock_sync_context.tsx-pack/plugins/maps/public/classes/styles/vector/properties/__tests__/test_util.ts@elastic/apm-ui
x-pack/plugins/apm/public/selectors/__tests__/mockData/anomalyData.ts@elastic/kibana-canvas #73121
x-pack/plugins/canvas/public/__tests__/setup.jsx-pack/plugins/canvas/public/components/loading/__tests__/loading.jsx-pack/plugins/canvas/public/functions/__tests__/asset.jsx-pack/plugins/canvas/public/lib/__tests__/find_expression_type.jsx-pack/plugins/canvas/public/lib/__tests__/history_provider.jsx-pack/plugins/canvas/public/lib/__tests__/modify_path.jsx-pack/plugins/canvas/public/lib/__tests__/resolved_arg.jsx-pack/plugins/canvas/public/state/actions/__tests__/elements.get_sibling_context.jsx-pack/plugins/canvas/public/state/reducers/__tests__/elements.jsx-pack/plugins/canvas/public/state/reducers/__tests__/fixtures/action_creator.jsx-pack/plugins/canvas/public/state/reducers/__tests__/resolved_args.jsx-pack/plugins/canvas/public/state/selectors/__tests__/resolved_args.jsx-pack/plugins/canvas/public/state/selectors/__tests__/workpad.js@elastic/stack-monitoring
x-pack/plugins/monitoring/public/components/alerts/__tests__/map_severity.jsx-pack/plugins/monitoring/public/components/chart/__tests__/get_color.jsx-pack/plugins/monitoring/public/components/chart/__tests__/get_last_value.jsx-pack/plugins/monitoring/public/components/chart/__tests__/get_title.jsx-pack/plugins/monitoring/public/components/chart/__tests__/get_values_for_legend.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/__tests__/config.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/__tests__/pipeline_state.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/boolean_edge.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/edge.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/edge_factory.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/if_vertex.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/index.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/plugin_vertex.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/queue_vertex.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/vertex.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/vertex_factory.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/if_statement.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/make_statement.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/pipeline.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/plugin_statement.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/queue.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/statement.jsx-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/utils.jsx-pack/plugins/monitoring/public/directives/main/__tests__/monitoring_main_controller.jsx-pack/plugins/monitoring/public/lib/__tests__/format_number.jsx-pack/plugins/monitoring/public/lib/logstash/__tests__/pipelines.jsx-pack/plugins/monitoring/public/services/__tests__/breadcrumbs.jsx-pack/plugins/monitoring/public/services/__tests__/executor.jsx-pack/plugins/monitoring/public/views/__tests__/base_controller.jsx-pack/plugins/monitoring/public/views/__tests__/base_table_controller.js@elastic/observability-ui (couldn't find the Uptime team alias)
x-pack/plugins/uptime/public/components/monitor/status_details/location_map/embeddables/__tests__/__mocks__/mock.ts--90% sure this isn't related to Karma, but got picked up by the same glob patternjest testThe text was updated successfully, but these errors were encountered: