[Ingest Manager] Removal of requirements in packages breaks UI

[ruflin]

In elastic/package-registry#574 requirements were renamed to conditions. I did not expect this to break the UI as requirements could also be empty / missing. But it seems it breaks the UI when accessing an integrations details page.

Removing some code related to requirements solves the issue.

My suggestion for 7.9 is to remove the code and UI completely and we rethink it moving forward.

To reproduce it, you need to check out the registry from master and run it locally.

[elasticmachine]

Pinging @elastic/ingest-management (Team:Ingest Management)

[jfsiii]

I don't know for sure what broke in Kibana, but the old golang struct https://github.com/elastic/package-registry/pull/574/files#diff-3c2c8ec3d107f7be6f8119cde040fbc0L63 says there will always be a requirement key

So

  "requirement": {
    "kibana": {
      "versions": "\u003e=7.3.0 \u003c8.0.0"
    },
    "elasticsearch": {
      "versions": "\u003e7.0.1"
    }
  },

or

  "requirement": {
  },

but not missing entirely

[jfsiii]

To reproduce it, you need to check out the registry from master and run it locally.

This is change is live on https://epr.elastic.co/

compare with experimental

So it can be reproduced most places. Here's a failing dev cluster

[ruflin]

The fix for it is here.

The part I missed when removing requirements is that it seems it was a requirement in Kibana to even have an empty field. If we reintroduce it as constraints, we should make sure it is optional.

[jfsiii]

The part I missed when removing requirements is that it seems it was a requirement in Kibana to even have an empty field.

I don't understand what you mean by empty field. Can you say more or give a code sample?

I'm new to golang but the TS types

kibana/x-pack/plugins/ingest_manager/common/types/models/epm.ts

Line 56 in d9fcc58

requirement: RequirementsByServiceName;

kibana/x-pack/plugins/ingest_manager/common/types/models/epm.ts

Line 138 in d9fcc58

export type RequirementsByServiceName = Record<ServiceName, ServiceRequirements>;

match my understanding of the struct https://github.com/elastic/package-registry/blob/33c9f9df5881a879ced083cc626ba973f928b32d/util/package.go#L63

and the example data

This seems like a breaking change on the registry response which means it impacts Kibana, but perhaps I'm misreading the code.

Along those lines, I'll open a PR to update the OpenAPI spec

[ruflin]

@jfsiii You are correct here. It was kind of a "bug" on the registry side that it was required, agree its a breaking change.