Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Migrate from using stream.* fields to dataset.* fields #67672

Closed
ph opened this issue May 28, 2020 · 3 comments · Fixed by #68322
Closed

[Ingest Manager] Migrate from using stream.* fields to dataset.* fields #67672

ph opened this issue May 28, 2020 · 3 comments · Fixed by #68322
Assignees
@jen-huang
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@ph
Copy link
Contributor

ph commented May 28, 2020 •
edited
Loading

We are planning to move the fields from using stream.* to dataset.* in elastic/package-registry#482

We will need to adjust our internal query to the new dataset prefix.

part of elastic/package-registry#491
@ph ph added Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels May 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang self-assigned this May 28, 2020
@ruflin
Copy link
Member

ruflin commented Jun 2, 2020 •
edited
Loading

@ph You have ingest.* fields above. Is this a typo?

@ph
Copy link
Contributor Author

ph commented Jun 2, 2020

Yes, good catch.

@jen-huang jen-huang mentioned this issue Jun 4, 2020
Merged
ruflin pushed a commit that referenced this issue Jun 9, 2020
@jen-huang
[Ingest Manager] Update queries from stream.* to dataset.* (#68322)
bc6aadd 
Resolves #67672

Part of elastic/package-registry#491

See elastic/package-registry#492 for package registry changes.

Updates existing queries to use `dataset.*` fields. from `stream.*` fields.

I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
jen-huang added a commit to jen-huang/kibana that referenced this issue Jun 9, 2020
@jen-huang
[Ingest Manager] Update queries from stream.* to dataset.* (elast…
9c89854 
…ic#68322)

Resolves elastic#67672

Part of elastic/package-registry#491

See elastic/package-registry#492 for package registry changes.

Updates existing queries to use `dataset.*` fields. from `stream.*` fields.

I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
jen-huang added a commit that referenced this issue Jun 9, 2020
@jen-huang
[Ingest Manager] Update queries from stream.* to dataset.* (#68322)…
73d30d9 
… (#68667)

Resolves #67672

Part of elastic/package-registry#491

See elastic/package-registry#492 for package registry changes.

Updates existing queries to use `dataset.*` fields. from `stream.*` fields.

I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jen-huang jen-huang

Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Ingest Manager] Update queries from stream.* to dataset.* jen-huang/kibana
4 participants
@ph @ruflin @jen-huang @elasticmachine