Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KQL support in filter ratio in TSVB #67503

Closed
AlonaNadler opened this issue May 27, 2020 · 2 comments · Fixed by #75033
Closed

KQL support in filter ratio in TSVB #67503

AlonaNadler opened this issue May 27, 2020 · 2 comments · Fixed by #75033
Assignees
@DianaDerevyankina
Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@AlonaNadler
Copy link

Describe the feature: Over the past few weeks, I got several requests and frustrated users who missed the fact filter ratio doesn't support KQL and couldnt figure why they get errors on valid kql queries in filter ratio in TSVB.
Currently there is no indication that filter ratio doesn't work with KQL and only supports Lucene. Users past queries that are working in Discover and get errors in TSVB which can't be explained.

Since KQL is the default starting from 7.0 it will be good to support it in TSVB filter ratio.

cc: @timroes
@AlonaNadler AlonaNadler added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added the enhancement New value added to drive a business result label May 27, 2020
@timroes
Copy link
Contributor

timroes commented Jul 21, 2020 •
edited
Loading

For reference the implementation when switching Filters aggregation in the visualize editor over to use KQL: #37287

DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue Aug 14, 2020
@DianaDerevyankina
KQL support in filter ratio in TSVB
33cc09e 
Closes elastic#67503
@DianaDerevyankina DianaDerevyankina mentioned this issue Aug 14, 2020
Merged
7 tasks
@wylieconlon wylieconlon mentioned this issue Aug 17, 2020
Closed
DianaDerevyankina added a commit that referenced this issue Aug 27, 2020
@DianaDerevyankina @alexwizp @elasticmachine
KQL support in filter ratio in TSVB (#75033)
8e2cb56 
* KQL support in filter ratio in TSVB

Closes #67503

* Fix filter_ratio and filter_ratios tests

* fix JEST

* Refactor some code in filter_ratio, filter_ratios, filter_ratios.test

* Edit query value in filter_ratio and filter_ratios.test

* Refacor some code in filter_ratio.js and visualization_migrations.ts

* Remove duplications in vis_schema and refactor filter_ratio

* Refactor filter_ratio.js

* Update default query with getDefaultQuery()

* Fix filter_ratio and histogram_support tests

Co-authored-by: Alexey Antonov <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue Aug 27, 2020
@DianaDerevyankina @alexwizp @elasticmachine
KQL support in filter ratio in TSVB (elastic#75033)
cecf3c9 
* KQL support in filter ratio in TSVB

Closes elastic#67503

* Fix filter_ratio and filter_ratios tests

* fix JEST

* Refactor some code in filter_ratio, filter_ratios, filter_ratios.test

* Edit query value in filter_ratio and filter_ratios.test

* Refacor some code in filter_ratio.js and visualization_migrations.ts

* Remove duplications in vis_schema and refactor filter_ratio

* Refactor filter_ratio.js

* Update default query with getDefaultQuery()

* Fix filter_ratio and histogram_support tests

Co-authored-by: Alexey Antonov <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
DianaDerevyankina added a commit that referenced this issue Aug 27, 2020
@DianaDerevyankina @alexwizp @elasticmachine
KQL support in filter ratio in TSVB (#75033) (#76071)
54dc88b 
* KQL support in filter ratio in TSVB

Closes #67503

* Fix filter_ratio and filter_ratios tests

* fix JEST

* Refactor some code in filter_ratio, filter_ratios, filter_ratios.test

* Edit query value in filter_ratio and filter_ratios.test

* Refacor some code in filter_ratio.js and visualization_migrations.ts

* Remove duplications in vis_schema and refactor filter_ratio

* Refactor filter_ratio.js

* Update default query with getDefaultQuery()

* Fix filter_ratio and histogram_support tests

Co-authored-by: Alexey Antonov <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Alexey Antonov <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DianaDerevyankina DianaDerevyankina

Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

KQL support in filter ratio in TSVB DianaDerevyankina/kibana
4 participants
@timroes @elasticmachine @AlonaNadler @DianaDerevyankina