Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require kbn-version header for HEAD requests #6449

Closed
spalger opened this issue Mar 7, 2016 · 4 comments
Closed

Don't require kbn-version header for HEAD requests #6449

spalger opened this issue Mar 7, 2016 · 4 comments

Comments

@spalger
Copy link
Contributor

spalger commented Mar 7, 2016

We currently require the kbn-version header for all non-GET requests, which allows users to load applications, but we should also exclude HEAD requests as it serves a very similar purpose to GET and should be safe to execute from any caller.

The reason this is specifically desired is so systems can make HEAD requests to /app/kibana and get a 200 or 503 depending on server status.

@ghost
Copy link

ghost commented Mar 8, 2016

Hey @spalger ! shouldn't that be "The reason this is specifically desired is so systems can make HEAD requests to /app/kibana"

And NOT "The reason this is specifically desired is so systems can make HEAD requests to /api/kibana"?

@ghost
Copy link

ghost commented Apr 22, 2016

Hey @spalger

How's it going? I just decided to try this again under kibana 4.5 and I'm getting the same result:

[root@varnish1:~] #HEAD http://logs1.example.com/app/kibana
400 Bad Request
Cache-Control: no-cache
Connection: close
Date: Fri, 22 Apr 2016 20:23:03 GMT
Server: nginx/1.8.1
Content-Type: application/json; charset=utf-8
Client-Date: Fri, 22 Apr 2016 20:23:04 GMT
Client-Peer: 52.72.210.180:80
Client-Response-Num: 1
Kbn-Name: kibana
Kbn-Version: 4.5.0

Is a fix still coming for this issue?

Thanks

@spalger
Copy link
Contributor Author

spalger commented Apr 24, 2016

@bluethundr This issue will be closed when the issue is fixed. Doesn't look like it's being worked on quite yet.

@ghost
Copy link

ghost commented Apr 25, 2016

Ok got it. Thanks for the heads up!

Tim

Sent from my iPhone

On Apr 24, 2016, at 2:50 PM, Spencer [email protected] wrote:

@bluethundr This issue will be closed when the issue is fixed. Doesn't look like it's being worked on quite yet.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants