Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statefull <SearchBar/> hardening #63675

Closed
Dosant opened this issue Apr 16, 2020 · 2 comments
Closed

Statefull <SearchBar/> hardening #63675

Dosant opened this issue Apr 16, 2020 · 2 comments
Labels
Feature:Filters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. technical debt Improvement of the software architecture and operational architecture triage_needed

Comments

@Dosant
Copy link
Contributor

Dosant commented Apr 16, 2020

In 7.7 we did a great job simplifying usage of a by adding use-defaults property. It allows to use with all the features (Filters, TimeRange, SavedQueries) with almost non configuration.

But there are use cases when use-defaults has to be used together with regular "controlled" inputs / outputs.
Looks like there are some edge cases could pop-up out in some scenarios causing infinite cycles of state updates. Example: #63505, #63561

I think we should review different combinations of props / state updates to properly fix the issue patched in #63505. Ideally we should also improve unit test coverage of that component and focus on making sure we are not getting into infinite loop with different props/use-defaults combination. We could also look into reducing react recalculations .

@Dosant Dosant added Feature:Filters triage_needed technical debt Improvement of the software architecture and operational architecture Team:AppArch labels Apr 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@exalate-issue-sync exalate-issue-sync bot removed the loe:small Small Level of Effort label May 12, 2022
@ppisljar
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Filters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. technical debt Improvement of the software architecture and operational architecture triage_needed
Projects
None yet
Development

No branches or pull requests

3 participants